Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out strategies to a separate repo #338

Open
CasperWA opened this issue Sep 21, 2023 · 0 comments
Open

Separate out strategies to a separate repo #338

CasperWA opened this issue Sep 21, 2023 · 0 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@CasperWA
Copy link
Contributor

Following some reflections in the OP of #337, I think it may be nice to split out the strategies to a separate repository (e.g., oteapi-core-strategies or something).

The main benefits:

  • Separate of concerns.
  • The strategies can still be installed as part of oteapi-core through an extra, e.g., oteapi-core[strategies] or similar.
  • It will greatly reduce the number of (unnecessary) dependencies, having plugins only install sub-dependencies that are actually necessary to use OTEAPI (see the full list in the updated pyproject.toml file in Sort dependencies #337.)

The main arguments against (that I can think of):

  • Doubles the maintenance.
  • Logical "usage" tests with strategies possibly becomes harder for this repository.
  • All packages currently depending on oteapi-core will immediately lose the strategies, until they update their dependency specification to include the strategies extra (or similar) or explicitly also depend on the separated out core strategies package.
@CasperWA CasperWA added enhancement New feature or request question Further information is requested labels Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant