Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add filter for accelerators and pytests #276

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

trz42
Copy link
Contributor

@trz42 trz42 commented Aug 21, 2024

This is a first PR towards better support for building for GPUs. It includes the following changes/additions:

  • a new filter component accelerator (that can be added to to bot: build ... commands)
  • adjusted processing of filter component names so that components must be given with at least three characters
  • improved definition and use of strings for raising exceptions if anything went wrong with providing filters
  • fixed code for removal of filters (the code was neither used nor tested, thus we were not aware that it would not always work)
  • added tests for the removal of filters and for the new filter component (accelerators)
  • updated tests that were broken by code changes

@laraPPr
Copy link
Collaborator

laraPPr commented Aug 23, 2024

@trz42 I have had a look and seems to look good. The only thing that is add in this pr is that you can pass accelorator in the bot command nothing more right? All the other stuff will than in an other PR right?

Copy link
Collaborator

@laraPPr laraPPr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@laraPPr laraPPr merged commit 5a950dc into EESSI:develop Aug 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants