Ship load out link error #617
Comments
|
Could you please copy and paste the full URL from the Firefox URL bar in each failing case ? Do it between backticks |
|
Example of bugged loadout event from journal |
|
|
|
here is the url and ship loadout for a corvette |
|
|
|
|
|
|
|
|
|
Those are the ones that gives errors, i have another cutter that works, and another 2 phytons that also work |
|
All of your URLs have a data value that is 2050 characters long. This very much points to them getting cut off by a length limit. You stated you're using Windows 7 and Mozilla Firefox. What version is the browser? It's possible that even if it's the latest (78.0.2) when it's on Windows 7 it has a URL length limit that's preventing this feature of EDMC from working. Let me test with one of the loadout files you provided.... |
|
If I take your DEATH.2020-07-18T20.43.24.txt file and run it through this script: from sys import argv
import json
import io
import gzip
import base64
def shipyard_url(loadout, is_beta):
string = json.dumps(loadout, ensure_ascii=False, sort_keys=True, separators=(',', ':')).encode('utf-8') # most compact representation
if not string:
return False
out = io.BytesIO()
with gzip.GzipFile(fileobj=out, mode='w') as f:
f.write(string)
return (is_beta and 'https://beta.coriolis.io/import?data=' or 'https://coriolis.io/import?data=') + base64.urlsafe_b64encode(out.getvalue()).decode().replace('=', '%3D')
loadout = ''
with open(argv[1], 'rt') as loadout_file:
loadout += loadout_file.read()
#print('Testing with:\n{}\n'.format(loadout))
loadout_json = json.loads(loadout)
loadout_string = json.dumps(loadout_json,
ensure_ascii=False,
sort_keys=True,
separators=(',', ':'),
indent=None,
)
print(shipyard_url(loadout_string, False))I get:
Which has 3075 characters in the data value. So your browser is definitely cutting something off. |
|
Of course coriolis also still fails to load that form of the URL, but it'll be for a different reason. |
|
ok that makes sense, I'm using ver 78.0.2 (64-bit). |
|
If you can give us a full Journal file for simply logging all the way in with one of the "doesn't work" loadouts, then I can test it my end to see if it's an actual bug with EDMC code or just your system not coping with overly long URLs. |
|
Is this what you are looking for? |
Yup, thanks. I'll take a look at it tomorrow. |
|
Just an update, if I import the txt file to coriolis it works. So I will use that in the mean time as a work around |
|
Also note that your FULL URLs are 2083 characters in length, and https://www.quora.com/What-is-the-max-length-for-URLs-in-each-browser?share=1 states:
So somehow your URL operations are still going through IE, even if they end up in FF !?!?!? |
|
What value do you have in the registry for EDMC code explicitly checks that, and if it finds that it's If you too have |
|
Please try out 4.0.3-rc3 . NB: If you happened to try any of the earlier 4.0.3-rcX series please uninstall EDMC first, then install -rc3. All your configuration and third-party plugins will be unaffected (assuming you put third-party plugins in the correct place, not the install folder!). |
|
So the HKEY_CURRENT_USER\Software\Microsoft\Windows\Shell\Associations\UrlAssociations\https\UserChoice\ProgId value is: I have uninstalled edmc and installed -rc3, but still get the same error |
|
|
|
I have also tried this with google Chrome, and get the same error |
|
Perhaps you didn't read the -rc3 release notes. Check the Configuration tab of settings and the new tickbox 'Use alternate URL method' next to the Shipyard choice. Activate that then try. |
|
Yes you are correct I did not read, that did the job |
|
Closing as 4.0.3 is out now with the alternate URL method option. |
Describe the bug
when clicking on your ship to get the build (either Coriolis or EDSY) both gives an import error :
Coriolis:
Jameson, we have a problem..
Failed to import ship
This does not happen to all my ships just some, not sure why some work and some don't
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Ship loadout should show in either Coriolis or EDSY.
Screenshots
Desktop (please complete the following information):
Not sure if it is an EDMC or Coriolis or FD problem
The text was updated successfully, but these errors were encountered: