Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example on writing an output file of hdf5 format #642

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Add example on writing an output file of hdf5 format #642

merged 2 commits into from
Jun 30, 2023

Conversation

dineshadepu
Copy link
Contributor

@dineshadepu dineshadepu commented Jun 27, 2023 •
edited
Loading

Added an example on output of hdf5 file format. Addresses on of the checklist on #605

streeve
streeve requested changes Jun 27, 2023
View reviewed changes
Copy link
Member

@streeve streeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start - a few changes and this should be ready to merge

example/core_tutorial/CMakeLists.txt Outdated Show resolved Hide resolved
example/core_tutorial/13_hdf5_output/hdf5_output_example.cpp Outdated Show resolved Hide resolved
example/core_tutorial/13_hdf5_output/hdf5_output_example.cpp Outdated Show resolved Hide resolved
example/core_tutorial/13_hdf5_output/hdf5_output_example.cpp Outdated Show resolved Hide resolved
example/core_tutorial/13_hdf5_output/hdf5_output_example.cpp Outdated Show resolved Hide resolved
example/core_tutorial/13_hdf5_output/hdf5_output_example.cpp Outdated Show resolved Hide resolved
example/core_tutorial/13_hdf5_output/CMakeLists.txt Outdated Show resolved Hide resolved
example/core_tutorial/13_hdf5_output/hdf5_output_example.cpp Outdated Show resolved Hide resolved
@streeve
Copy link
Member

streeve commented Jun 27, 2023

Also note this will need to be formatted with clang-format

@dineshadepu
Copy link
Contributor Author

I have updated the file with the changes.

@dineshadepu
Copy link
Contributor Author

I have squashed the commits and made into a single commit. Updated the files as requested.

@streeve
Copy link
Member

streeve commented Jun 30, 2023

Look good to you @brtnfld?

brtnfld
brtnfld approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@brtnfld brtnfld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@streeve
Copy link
Member

streeve commented Jun 30, 2023

HIP timeout unrelated

@streeve streeve merged commit 352487c into ECP-copa:master Jun 30, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streeve streeve streeve approved these changes

@brtnfld brtnfld brtnfld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dineshadepu @streeve @brtnfld