Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# 7.x: numeric literal syntax improvements #45

Merged

Conversation

RexJaeschke
Copy link
Contributor

@RexJaeschke RexJaeschke commented Nov 24, 2020

Added support for the following:

  • V7.0 binary integer literals
  • V7.0 digit separators in numeric literals
  • V7.2 leading underscore(s) in binary and hex integer literals

@RexJaeschke RexJaeschke changed the title C# V7.* numeric literal syntax improvements C# 7.* numeric literal syntax improvements Nov 24, 2020
@RexJaeschke RexJaeschke changed the title C# 7.* numeric literal syntax improvements C# 7.x numeric literal syntax improvements Nov 24, 2020
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

@BillWagner
Copy link
Member

ping @jskeet Do you want to start reviewing V7 features in meetings? Or, what label should we apply for general committee review?

@jskeet
Copy link
Contributor

jskeet commented Dec 2, 2020

I would prefer to go through all the V6 features before we start on V7. Aside from anything else, that way we can merge all the V6 changes and check for collisions before anyone reviews. Does that sound okay?

@BillWagner BillWagner added this to the C# 7.x milestone Dec 2, 2020
@BillWagner
Copy link
Member

Sounds good. I created a C# 7.x milestone, and added this PR to that milestone.

@RexJaeschke RexJaeschke changed the title C# 7.x numeric literal syntax improvements C# 7.x: numeric literal syntax improvements Dec 14, 2020
@RexJaeschke RexJaeschke merged commit edfe37a into draft-v7 Feb 5, 2021
@RexJaeschke RexJaeschke deleted the RexJaeschke-integer-and-float-literal-additions branch February 5, 2021 21:57
@RexJaeschke RexJaeschke restored the RexJaeschke-integer-and-float-literal-additions branch November 30, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants