Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# 7.x: non-trailing named args #216

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Conversation

RexJaeschke
Copy link
Contributor

No description provided.

@RexJaeschke RexJaeschke added this to the C# 7.x milestone Jan 26, 2021
@RexJaeschke RexJaeschke added the Review: pending Proposal is available for review label Sep 16, 2021
@BillWagner BillWagner marked this pull request as draft February 3, 2022 15:03
@BillWagner
Copy link
Member

Converting to draft until we're ready for C# 7

@BillWagner BillWagner force-pushed the Rex-v7-nontrailing-named-args branch from acda4ac to 6e2316f Compare April 3, 2022 01:19
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding suggestion

standard/expressions.md Outdated Show resolved Hide resolved
@BillWagner
Copy link
Member

@RexJaeschke I think this is ready. I'll remove the draft status so it's in my queue to review.

@BillWagner BillWagner marked this pull request as ready for review October 2, 2022 21:29
@BillWagner BillWagner force-pushed the Rex-v7-nontrailing-named-args branch from 5423185 to e187785 Compare October 2, 2022 21:30
@jskeet jskeet self-requested a review October 25, 2022 08:17
standard/expressions.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments that should be discussed, but I think we should be able to get them resolved and get the PR merged in our next meeting.

standard/expressions.md Outdated Show resolved Hide resolved
@jskeet jskeet added Review: complete at least one person has reviewed this meeting: discuss This issue should be discussed at the next TC49-TG2 meeting and removed Review: pending Proposal is available for review labels Oct 26, 2022
@jskeet jskeet self-assigned this Oct 26, 2022
Copy link
Contributor

@Nigel-Ecma Nigel-Ecma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is short and clear, though I wonder why it was added [*] I think we can approve it.

Oh, and I think we should stick with "following"

[*] It doesn't seem to add much of benefit. It would have made more sense to me if M(b: false, cValue) was supported, i.e. accept the defaults before b and give values for b onwards.

@jskeet
Copy link
Contributor

jskeet commented Nov 30, 2022

It doesn't seem to add much of benefit

I've definitely found it useful in real code. It's not that unusual to have a set of arguments that are already in positional order, but you want to clarify two arguments of the same type, without specifying the names of all the arguments from there onwards.

jskeet and others added 2 commits November 30, 2022 20:26
Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed at 2022-11-30 meeting.

@BillWagner
Copy link
Member

closing and reopening

@BillWagner BillWagner closed this Nov 30, 2022
@BillWagner BillWagner reopened this Nov 30, 2022
@BillWagner BillWagner merged commit ef91733 into draft-v7 Nov 30, 2022
@BillWagner BillWagner deleted the Rex-v7-nontrailing-named-args branch November 30, 2022 20:33
BillWagner added a commit to BillWagner/docs that referenced this pull request Dec 1, 2022
The standard committe has merged the updates to the standard for the following features:

- dotnet/csharpstandard#216 - non-trailing named arguments
- dotnet/csharpstandard#236 - default literals

Remove the feature speclets from the publishing list, and fix any related links.
BillWagner added a commit to dotnet/docs that referenced this pull request Dec 2, 2022
* remove feature specs

The standard committe has merged the updates to the standard for the following features:

- dotnet/csharpstandard#216 - non-trailing named arguments
- dotnet/csharpstandard#236 - default literals

Remove the feature speclets from the publishing list, and fix any related links.

* add redirections

Add the redirections for removed proposal specs.

* fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meeting: discuss This issue should be discussed at the next TC49-TG2 meeting Review: complete at least one person has reviewed this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants