Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define p value type in the field label of the data file #3

Open
jdhayhurst opened this issue Aug 1, 2022 · 1 comment
Open

Define p value type in the field label of the data file #3

jdhayhurst opened this issue Aug 1, 2022 · 1 comment

Comments

@jdhayhurst
Copy link
Contributor

As with effect statistic (beta, odds_ratio, hazard_ratio), could define the p value type (standard or -log10) in the field label itself instead of, or as well as, in the metadata. This would be consistent with the effect statistic handling and also allows users to interpret the data without reading the metadata file.

@marcora
Copy link

marcora commented Sep 8, 2022

Another reason why separating sumstats from metadata in two different files is a weakness of the GWAS-SSF format in my opinion (in contrast to GWAS-VCF for example), particularly as it pertains to data integrity and self-contained documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants