-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix phase field not updating #614
Conversation
src/testing/e2e/integrationtests/oneagent_controller_integration_test.go
Outdated
Show resolved
Hide resolved
The phase field is updated initially while the deamonset is first deployed. However, if a oneagent pod is deleted after the phase has been set to running, it is not updated to read "Deploying" again. Is this expected behaviour? |
It should reset the phase to "Deploying" as the phase is determined on every oneagent reconcile which happens on every dynakube reconcile. The phase field in general is not implemented well, a more structured phase handling is done in the following PR: #609 |
Description
The oneagent reconciler references the wrong daemonset and therefore never updates the phase field.
How can this be tested?
Deploy full stack monitoring and watch the phase field. => Should be "Running" after dynakube reconciliation.
Checklist