-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to distroless base image #596
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luhi-DT
previously approved these changes
Feb 22, 2022
gkrenn
previously approved these changes
Feb 23, 2022
0sewa0
requested changes
Feb 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the csi driver doesn't work, I guess it uses the mount
command that is not part of the distroless image
{"level":"info","ts":"2022-02-23T15:10:02.413Z","logger":"csi-driver","msg":"publishing volume","csiMode":"app","target":"/var/lib/kubelet/pods/d18175ca-0eac-4629-8ef7-2f35f4a954c3/volumes/kubernetes.io~csi/oneagent-bin/mount","fstype":"","readonly":false,"volumeID":"csi-806275e95d7941da0bb2b29c956fc2197b348e65338384ffcd12fa683c033099","attributes":{"csi.storage.k8s.io/ephemeral":"true","csi.storage.k8s.io/pod.name":"java-glibc-56978775fb-mvgzh","csi.storage.k8s.io/pod.namespace":"java-sample","csi.storage.k8s.io/pod.uid":"d18175ca-0eac-4629-8ef7-2f35f4a954c3","csi.storage.k8s.io/serviceAccount.name":"default","dynakube":"dynakube","mode":"app"},"mountflags":[]}
/go/pkg/mod/google.golang.org/grpc@v1.43.0/server.go:921","ts":"2022-02-23T15:10:01.303Z"}E0223 15:10:02.413837 1 mount_linux.go:150] Mount failed: exec: "mount": executable file not found in $PATH
Mounting command: mount
Mounting arguments: -t overlay -o lowerdir=/data/zib50933/bin/1.237.0.20220223-091210,upperdir=/data/zib50933/run/csi-806275e95d7941da0bb2b29c956fc2197b348e65338384ffcd12fa683c033099/var,workdir=/data/zib50933/run/csi-806275e95d7941da0bb2b29c956fc2197b348e65338384ffcd12fa683c033099/work overlay /data/zib50933/run/csi-806275e95d7941da0bb2b29c956fc2197b348e65338384ffcd12fa683c033099/mapped
Output:
{"error":"rpc error: code = Internal desc = failed to mount oneagent volume: mount failed: exec: \"mount\": executable file not found in $PATH
Mounting command: mount
gkrenn
previously approved these changes
Mar 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add glibc versions of mount/umount
- Fix livenessprobe of csi registrar
0sewa0
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #531