-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maps EEC/StatsD-related annotations to the EEC and data sources runtime properties #582
Merged
toszr
merged 5 commits into
master
from
feature/statsd-ingest--runtime-props-in-dynakube
Feb 22, 2022
Merged
Maps EEC/StatsD-related annotations to the EEC and data sources runtime properties #582
toszr
merged 5 commits into
master
from
feature/statsd-ingest--runtime-props-in-dynakube
Feb 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0sewa0
requested changes
Feb 18, 2022
src/controllers/activegate/reconciler/capability/eec_runtime_config.go
Outdated
Show resolved
Hide resolved
toszr
force-pushed
the
feature/statsd-ingest--runtime-props-in-dynakube
branch
from
February 18, 2022 14:57
171b807
to
3a124d1
Compare
chrismuellner
previously requested changes
Feb 18, 2022
src/controllers/activegate/reconciler/statefulset/container_eec.go
Outdated
Show resolved
Hide resolved
src/controllers/activegate/reconciler/capability/eec_runtime_config_test.go
Outdated
Show resolved
Hide resolved
src/controllers/activegate/reconciler/capability/eec_runtime_config.go
Outdated
Show resolved
Hide resolved
src/controllers/activegate/reconciler/capability/reconciler_eec_runtime_config.go
Outdated
Show resolved
Hide resolved
src/controllers/activegate/reconciler/capability/reconciler_eec_runtime_config.go
Outdated
Show resolved
Hide resolved
src/controllers/activegate/reconciler/statefulset/container_eec.go
Outdated
Show resolved
Hide resolved
src/controllers/activegate/reconciler/capability/reconciler_eec_runtime_config.go
Outdated
Show resolved
Hide resolved
Annotations starting with |
OK, changed the prefix to |
0sewa0
previously approved these changes
Feb 22, 2022
…EEC container (corresponds to feature flags but OneAgent-like)
toszr
force-pushed
the
feature/statsd-ingest--runtime-props-in-dynakube
branch
from
February 22, 2022 13:32
23b2a66
to
7c5bdb1
Compare
0sewa0
approved these changes
Feb 22, 2022
toszr
dismissed
chrismuellner’s stale review
February 22, 2022 14:19
Implemented changes from review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension Controller and data sources (like StatsD) can be configured in OneAgent/ActiveGate bare metal deployments using runtime properties (a.k.a. debug flags). In a bare metal AG setup, the interface is a json file stored at
/var/lib/dynatrace/remotepluginmodule/agent/conf/runtime/runtimeConfiguration
.This changeset converts EEC/StatsD debug flags defined as
DynaKube
annotations with prefixalpha.operator.dynatrace.com/extensions.
into valid runtime properties mounted into EEC container via a config map.Example:
is turned into: