Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New data-ingest endpoint secret containing data-ingest URL and token mounted to micrometer pods #322

Merged
merged 4 commits into from
Nov 18, 2021
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion config/common/operator/clusterrole-operator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ rules:
- secrets
resourceNames:
- dynatrace-dynakube-config
- dynatrace-data-ingest-endpoint
verbs:
- get
- update
Expand Down Expand Up @@ -95,4 +96,4 @@ rules:
- customresourcedefinitions
verbs:
- list
- watch
- watch
1 change: 1 addition & 0 deletions config/common/webhook/clusterrole-webhook.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ rules:
- secrets
resourceNames:
- dynatrace-dynakube-config
- dynatrace-data-ingest-endpoint
verbs:
- get
- list
Expand Down
6 changes: 6 additions & 0 deletions controllers/dynakube/dynakube_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import (
"github.com/Dynatrace/dynatrace-operator/controllers/dtversion"
"github.com/Dynatrace/dynatrace-operator/controllers/dynakube/status"
"github.com/Dynatrace/dynatrace-operator/controllers/dynakube/updates"
dtingestendpoint "github.com/Dynatrace/dynatrace-operator/controllers/ingestendpoint"
"github.com/Dynatrace/dynatrace-operator/controllers/istio"
"github.com/Dynatrace/dynatrace-operator/controllers/oneagent"
"github.com/Dynatrace/dynatrace-operator/controllers/oneagent/daemonset"
Expand Down Expand Up @@ -260,6 +261,11 @@ func (r *ReconcileDynaKube) reconcileDynaKube(ctx context.Context, dkState *cont
if dkState.Error(err) || dkState.Update(upd, defaultUpdateInterval, "new init script created") {
return
}

upd, err = dtingestendpoint.NewEndpointGenerator(r.client, r.apiReader, dkState.Instance.Namespace, r.logger).GenerateForDynakube(ctx, dkState.Instance)
if dkState.Error(err) || dkState.Update(upd, defaultUpdateInterval, "new data-ingest endpoint secret created") {
return
}
} else {
if err := dkMapper.UnmapFromDynaKube(); err != nil {
dkState.Log.Error(err, "could not unmap dynakube from namespace")
Expand Down
114 changes: 114 additions & 0 deletions controllers/ingestendpoint/secret.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,114 @@
package ingestendpoint

import (
"bytes"
"context"
"fmt"

dynatracev1beta1 "github.com/Dynatrace/dynatrace-operator/api/v1beta1"
"github.com/Dynatrace/dynatrace-operator/controllers/kubeobjects"
"github.com/Dynatrace/dynatrace-operator/dtclient"
"github.com/Dynatrace/dynatrace-operator/mapper"
"github.com/Dynatrace/dynatrace-operator/webhook"
"github.com/go-logr/logr"
"github.com/pkg/errors"
corev1 "k8s.io/api/core/v1"
"sigs.k8s.io/controller-runtime/pkg/client"
)

const (
UrlSecretField = "DT_METRICS_INGEST_URL"
TokenSecretField = "DT_METRICS_INGEST_API_TOKEN"
configFile = "endpoint.properties"
)

// EndpointSecretGenerator manages the mint endpoint secret generation for the user namespaces.
type EndpointSecretGenerator struct {
client client.Client
apiReader client.Reader
logger logr.Logger
namespace string
}

func NewEndpointGenerator(client client.Client, apiReader client.Reader, ns string, logger logr.Logger) *EndpointSecretGenerator {
return &EndpointSecretGenerator{
client: client,
apiReader: apiReader,
namespace: ns,
logger: logger,
}
}

// GenerateForNamespace creates the data-ingest-endpoint secret for namespace while only having the name of the corresponding dynakube
// Used by the podInjection webhook in case the namespace lacks the secret.
func (g *EndpointSecretGenerator) GenerateForNamespace(ctx context.Context, dkName, targetNs string) (bool, error) {
g.logger.Info("Reconciling data-ingest endpoint secret for", "namespace", targetNs)
var dk dynatracev1beta1.DynaKube
if err := g.client.Get(ctx, client.ObjectKey{Name: dkName, Namespace: g.namespace}, &dk); err != nil {
return false, err
}

data, err := g.prepare(ctx, &dk)
if err != nil {
return false, err
}
return kubeobjects.CreateOrUpdateSecretIfNotExists(g.client, g.apiReader, webhook.SecretEndpointName, targetNs, data, corev1.SecretTypeOpaque, g.logger)
}

// GenerateForDynakube creates/updates the data-ingest-endpoint secret for EVERY namespace for the given dynakube.
// Used by the dynakube controller during reconcile.
func (g *EndpointSecretGenerator) GenerateForDynakube(ctx context.Context, dk *dynatracev1beta1.DynaKube) (bool, error) {
g.logger.Info("Reconciling data-ingest endpoint secret for", "dynakube", dk.Name)

data, err := g.prepare(ctx, dk)
if err != nil {
return false, err
}

anyUpdate := false
nsList, err := mapper.GetNamespacesForDynakube(ctx, g.apiReader, dk.Name)
if err != nil {
return false, err
}
for _, targetNs := range nsList {
if upd, err := kubeobjects.CreateOrUpdateSecretIfNotExists(g.client, g.apiReader, webhook.SecretEndpointName, targetNs.Name, data, corev1.SecretTypeOpaque, g.logger); err != nil {
return upd, err
} else if upd {
anyUpdate = true
}
}
g.logger.Info("Done updating data-ingest endpoint secrets")
return anyUpdate, nil
}

func (g *EndpointSecretGenerator) prepare(ctx context.Context, dk *dynatracev1beta1.DynaKube) (map[string][]byte, error) {
fields, err := g.PrepareFields(ctx, dk)
if err != nil {
return nil, errors.WithStack(err)
}

var endpointBuf bytes.Buffer
if _, err := endpointBuf.WriteString(fmt.Sprintf("%s=%s\n", UrlSecretField, fields[UrlSecretField])); err != nil {
return nil, errors.WithStack(err)
}
if _, err := endpointBuf.WriteString(fmt.Sprintf("%s=%s\n", TokenSecretField, fields[TokenSecretField])); err != nil {
return nil, errors.WithStack(err)
}

data := map[string][]byte{
configFile: endpointBuf.Bytes(),
}
return data, nil
}

func (g *EndpointSecretGenerator) PrepareFields(ctx context.Context, dk *dynatracev1beta1.DynaKube) (map[string]string, error) {
var tokens corev1.Secret
if err := g.client.Get(ctx, client.ObjectKey{Name: dk.Tokens(), Namespace: g.namespace}, &tokens); err != nil {
return nil, errors.WithMessage(err, "failed to query tokens")
}

return map[string]string{
UrlSecretField: fmt.Sprintf("%s/v2/metrics/ingest", dk.Spec.APIURL),
TokenSecretField: string(tokens.Data[dtclient.DynatraceDataIngestToken]),
}, nil
}
Loading