-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add statsd ingest #313
Merged
Merged
Add statsd ingest #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toszr
requested review from
meik99,
0sewa0,
baichinger,
mjgrzybek,
DTMad and
aorcholski
October 19, 2021 12:44
toszr
force-pushed
the
feature/statsd-ingest
branch
from
October 19, 2021 15:29
d7b9c60
to
06af78e
Compare
toszr
force-pushed
the
feature/statsd-ingest
branch
from
October 28, 2021 06:09
d98eec0
to
f37a428
Compare
chrismuellner
requested changes
Nov 15, 2021
controllers/activegate/reconciler/statefulset/container_statsd.go
Outdated
Show resolved
Hide resolved
toszr
force-pushed
the
feature/statsd-ingest
branch
2 times, most recently
from
November 23, 2021 17:36
921fa1d
to
e879115
Compare
toszr
force-pushed
the
feature/statsd-ingest
branch
from
December 17, 2021 11:15
e879115
to
bd336ba
Compare
0sewa0
reviewed
Jan 3, 2022
0sewa0
reviewed
Jan 3, 2022
0sewa0
reviewed
Jan 3, 2022
src/controllers/activegate/reconciler/statefulset/container_eec.go
Outdated
Show resolved
Hide resolved
0sewa0
reviewed
Jan 3, 2022
src/controllers/activegate/reconciler/statefulset/statefulset.go
Outdated
Show resolved
Hide resolved
toszr
force-pushed
the
feature/statsd-ingest
branch
2 times, most recently
from
January 25, 2022 07:58
a87281b
to
b839ac7
Compare
chrismuellner
requested changes
Jan 31, 2022
src/controllers/activegate/reconciler/statefulset/statefulset.go
Outdated
Show resolved
Hide resolved
src/controllers/activegate/reconciler/statefulset/statefulset_testutils_test.go
Outdated
Show resolved
Hide resolved
src/controllers/activegate/reconciler/statefulset/statefulset_testutils_test.go
Outdated
Show resolved
Hide resolved
src/controllers/activegate/reconciler/statefulset/statefulset.go
Outdated
Show resolved
Hide resolved
src/controllers/activegate/reconciler/statefulset/statefulset.go
Outdated
Show resolved
Hide resolved
toszr
force-pushed
the
feature/statsd-ingest
branch
from
February 2, 2022 11:51
b839ac7
to
090f446
Compare
chrismuellner
requested changes
Feb 2, 2022
…d on reconciliation Added StatsD UDP port to the ActiveGate service Hide StatsD and EEC containers under feature flag 'enable-statsd' Added feature flag 'use-activegate-image-for-statsd' to control whether custom entry points are needed for StatsD/EEC containers Add/remove StatsD port from ActiveGate service on reconciliation if the relevant feature flag had been changed Added integration test for ActiveGate service update on StatsD feature flags change; Some refactoring around service reconciler tests Implemented review comments (moved getTenantId() to properties.go, import renames etc.) Removed eec-config volume placeholder (will be addressed separately) Improved updating container ports based on their names Fixed unit tests and logger references Refactored unit tests Fix ActiveGate-related container and port names
…ad of relying on an internal annotation
toszr
force-pushed
the
feature/statsd-ingest
branch
from
February 2, 2022 20:13
0b75e7e
to
5ef1230
Compare
chrismuellner
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset enhances ActiveGate routing capability with the StatsD interface.
To enable, set the following feature flags to true:
alpha.operator.dynatrace.com/feature-enable-statsd
alpha.operator.dynatrace.com/feature-use-activegate-image-for-statsd
(use custom ActiveGate image with built-in StatsD and EEC)If enabled, the routing ActiveGate pod will include two new StatsD ingest-related containers (Extension Controller and StatsD data source), and the ActiveGate service will include an extra UDP port for StatsD packets (
:18125
).