From d0404c8048be1510883d696aab7932d70fb9058d Mon Sep 17 00:00:00 2001
From: jesusalvino <jesus.alvino@globant.com>
Date: Wed, 13 Apr 2022 23:51:07 -0500
Subject: [PATCH 1/9] Preventing Special Characters in the Publish Package

---
 src/DynamoCore/Search/SearchDictionary.cs     |  12 +-
 .../Properties/Resources.Designer.cs          |   2 +-
 .../Properties/Resources.en-US.resx           |   2 +-
 src/DynamoCoreWpf/Properties/Resources.resx   |   2 +-
 .../UI/Themes/Modern/DynamoModern.xaml        | 156 ++++++++++++++----
 .../PackageManager/PublishPackageViewModel.cs |  56 ++++++-
 .../PackageManager/PublishPackageView.xaml    |   3 +-
 7 files changed, 189 insertions(+), 44 deletions(-)

diff --git a/src/DynamoCore/Search/SearchDictionary.cs b/src/DynamoCore/Search/SearchDictionary.cs
index c14deb84ce2..476987cf842 100644
--- a/src/DynamoCore/Search/SearchDictionary.cs
+++ b/src/DynamoCore/Search/SearchDictionary.cs
@@ -323,11 +323,17 @@ private static string[] SplitOnWhiteSpace(string s)
             return s.Split(null);
         }
 
-        private static bool ContainsSpecialCharacters(string element)
+        public static Char[] SpecialAndInvalidCharacters()
         {
-            return element.Contains("*") || element.Contains(".") || element.Contains(" ")
-                || element.Contains("\\");
+            return new[] { '*', '.', ' ', '\\', '/', ':', '?', '<', '>', '|', '"' };
         }
+
+        public static bool ContainsSpecialCharacters(string element)
+        {
+            Char[] invalidCharacters = SpecialAndInvalidCharacters();
+            return (!string.IsNullOrEmpty(element) && element.IndexOfAny(invalidCharacters) >= 0);
+        }
+
         #endregion
 
         /// <summary>
diff --git a/src/DynamoCoreWpf/Properties/Resources.Designer.cs b/src/DynamoCoreWpf/Properties/Resources.Designer.cs
index 167b0a73b40..ee0e3ffb027 100644
--- a/src/DynamoCoreWpf/Properties/Resources.Designer.cs
+++ b/src/DynamoCoreWpf/Properties/Resources.Designer.cs
@@ -4795,7 +4795,7 @@ public static string PackageManagerPackageUpdated {
         }
         
         /// <summary>
-        ///   Looks up a localized string similar to The name of the package cannot contain /,\, or *..
+        ///   Looks up a localized string similar to The name of the package cannot contain.
         /// </summary>
         public static string PackageNameCannotContainTheseCharacters {
             get {
diff --git a/src/DynamoCoreWpf/Properties/Resources.en-US.resx b/src/DynamoCoreWpf/Properties/Resources.en-US.resx
index c5aae02a7b5..bfd1f4eb749 100644
--- a/src/DynamoCoreWpf/Properties/Resources.en-US.resx
+++ b/src/DynamoCoreWpf/Properties/Resources.en-US.resx
@@ -1528,7 +1528,7 @@ Next assemblies were loaded several times:
 {0}</value>
   </data>
   <data name="PackageNameCannotContainTheseCharacters" xml:space="preserve">
-    <value>The name of the package cannot contain /,\, or *.</value>
+    <value>The name of the package cannot contain</value>
     <comment>ErrorString</comment>
   </data>
   <data name="PackageNeedAtLeastOneFile" xml:space="preserve">
diff --git a/src/DynamoCoreWpf/Properties/Resources.resx b/src/DynamoCoreWpf/Properties/Resources.resx
index e3c0eb3c4c4..8804ecc1a21 100644
--- a/src/DynamoCoreWpf/Properties/Resources.resx
+++ b/src/DynamoCoreWpf/Properties/Resources.resx
@@ -1640,7 +1640,7 @@ If the toggle is off custom packages that are not already loaded will load once
     <comment>ErrorString</comment>
   </data>
   <data name="PackageNameCannotContainTheseCharacters" xml:space="preserve">
-    <value>The name of the package cannot contain /,\, or *.</value>
+    <value>The name of the package cannot contain</value>
     <comment>ErrorString</comment>
   </data>
   <data name="PackageNeedAtLeastOneFile" xml:space="preserve">
diff --git a/src/DynamoCoreWpf/UI/Themes/Modern/DynamoModern.xaml b/src/DynamoCoreWpf/UI/Themes/Modern/DynamoModern.xaml
index 1b17564834c..7dda090c298 100644
--- a/src/DynamoCoreWpf/UI/Themes/Modern/DynamoModern.xaml
+++ b/src/DynamoCoreWpf/UI/Themes/Modern/DynamoModern.xaml
@@ -119,6 +119,40 @@
         <Setter Property="Background" Value="#343434" />
     </Style>
 
+    <!--  Generic Dynamo ToolTip  -->
+    <Style x:Key="GenericToolTipLight" TargetType="ToolTip">
+        <Setter Property="OverridesDefaultStyle" Value="true" />
+        <Setter Property="MaxWidth" Value="300" />
+        <Setter Property="Template">
+            <Setter.Value>
+                <ControlTemplate TargetType="ToolTip">
+                    <Grid x:Name="PopupGrid">
+                        <Grid x:Name="ShadowBackground" Background="Transparent">
+                            <Path Margin="5 0 0 0" Width="20" Height="6" HorizontalAlignment="Left" VerticalAlignment="Top" Data="M0,6 L6,0 12,6Z" Stroke="Gray" Fill="White" Stretch="None" />
+                            <Border BorderThickness="1 0 1 1" CornerRadius="3" Margin="0 5 7 7" BorderBrush="#999999" Background="white" Padding="10,8">
+                                <ContentPresenter/>
+                            </Border>
+                            <Border BorderThickness="0 1 0 0" CornerRadius="0 0 3 0" Margin="16 5 9 0" HorizontalAlignment="Stretch" VerticalAlignment="Top" Height="7" BorderBrush="#999999" />
+                            <Border BorderThickness="0 1 0 0" CornerRadius="3 0 0 0" Margin="0 5 0 0"  HorizontalAlignment="Left" VerticalAlignment="Top" Height="7" Width="6" BorderBrush="#999999" />
+                        </Grid>
+                    </Grid>
+                </ControlTemplate>
+            </Setter.Value>
+        </Setter>
+        <Style.Resources>
+            <Style TargetType="ContentPresenter">
+                <Style.Resources>
+                    <Style TargetType="TextBlock">
+                        <Setter Property="TextWrapping" Value="Wrap" />
+                        <Setter Property="FontFamily" Value="{StaticResource ArtifaktElementRegular}" />
+                        <Setter Property="FontSize" Value="12px" />
+                        <Setter Property="Foreground" Value="#232323" />
+                    </Style>
+                </Style.Resources>
+            </Style>
+        </Style.Resources>
+    </Style>
+    
     <Image x:Key="ComboDownIcon_normal" Source="pack://application:,,,/DynamoCoreWpf;component/UI/Images/tick_selected.png" />
 
     <ControlTemplate x:Key="ComboBoxToggleButton" TargetType="ToggleButton">
@@ -723,6 +757,94 @@
         </Setter>
     </Style>
 
+    <Style x:Key="InputStyleWithIcon" TargetType="{x:Type TextBox}">
+        <Setter Property="Margin" Value="0,0,0,12" />
+        <Setter Property="MinWidth" Value="62px" />
+        <Setter Property="CaretBrush" Value="{StaticResource PrimaryCharcoal200Brush}" />
+        <Setter Property="Padding" Value="10,12,10,8"/>
+        <Setter Property="FontFamily" Value="{StaticResource ArtifaktElementRegular}"/>
+        <Setter Property="FontSize" Value="12px" />
+        <Setter Property="Foreground" Value="{StaticResource PrimaryCharcoal200Brush}"/>
+        <Setter Property="TextWrapping" Value="Wrap"/>
+
+        <Setter Property="Template">
+            <Setter.Value>
+                <ControlTemplate TargetType="{x:Type TextBox}">
+                    <Grid>
+                        <Grid.ColumnDefinitions>
+                            <ColumnDefinition />
+                            <ColumnDefinition Width="25" />
+                        </Grid.ColumnDefinitions>
+                        <Border Grid.Row="0"
+							Grid.ColumnSpan="2"
+                            Background="#353535"
+                            BorderBrush="Transparent"                            
+                            BorderThickness="1"
+                            />
+                        <ScrollViewer x:Name="PART_ContentHost" VerticalAlignment="Center"/>
+                        <Label  x:Name="WaterMarkLabel"
+								Grid.Row="0"
+                                Padding="13,13,10,8"
+                                Content="{TemplateBinding Tag}" 
+                                VerticalAlignment="Center"
+                                Visibility="Collapsed"
+                                FontFamily="{StaticResource ArtifaktElementRegular}"
+                                FontSize="12px"
+                                Foreground="{StaticResource PrimaryCharcoal200Brush}"
+                                IsHitTestVisible="False"
+                                Opacity="0.5"/>
+                        <!--  This is the Canvas for the exclamation mark appearing when the Style that the user is trying to insert already exists  -->
+                        <Canvas Grid.Column="1" Margin="0,5,5,0"
+                                Visibility="{Binding Path=IsWarningEnabled, Converter={StaticResource BooleanToVisibilityConverter}}">
+                            <Canvas.ToolTip>
+                                <ToolTip Content="{Binding CurrentWarningMessage}" Style="{StaticResource GenericToolTipLight}"/>
+                            </Canvas.ToolTip>
+                            <Path Fill="#FAA21B">
+                                <Path.Data>
+                                    <CombinedGeometry GeometryCombineMode="Exclude">
+                                        <CombinedGeometry.Geometry1>
+                                            <PathGeometry>
+                                                <PathGeometry.Figures>
+                                                    <PathFigureCollection>
+                                                        <PathFigure IsClosed="True" StartPoint="10,5">
+                                                            <PathFigure.Segments>
+                                                                <PathSegmentCollection>
+                                                                    <LineSegment Point="18,20" />
+                                                                    <LineSegment Point="2,20" />
+                                                                </PathSegmentCollection>
+                                                            </PathFigure.Segments>
+                                                        </PathFigure>
+                                                    </PathFigureCollection>
+                                                </PathGeometry.Figures>
+                                            </PathGeometry>
+                                        </CombinedGeometry.Geometry1>
+                                        <CombinedGeometry.Geometry2>
+                                            <GeometryGroup FillRule="EvenOdd">
+                                                <EllipseGeometry Center="10,18" RadiusX="1.5" RadiusY="1.5"/>
+                                                <RectangleGeometry Rect="8.5,8.5,3,7.5"/>
+                                            </GeometryGroup>
+                                        </CombinedGeometry.Geometry2>
+                                    </CombinedGeometry>
+                                </Path.Data>
+                            </Path>
+                        </Canvas>
+                    </Grid>
+                    <ControlTemplate.Triggers>
+                        <MultiTrigger>
+                            <MultiTrigger.Conditions>
+                                <Condition Property="Text" Value=""/>
+                            </MultiTrigger.Conditions>
+                            <Setter Property="Visibility" TargetName="WaterMarkLabel" Value="Visible"/>
+                        </MultiTrigger>
+                        <Trigger Property="IsEnabled" Value="False">
+                            <Setter Property="Foreground" Value="{StaticResource PrimaryCharcoal200Brush}"/>
+                        </Trigger>
+                    </ControlTemplate.Triggers>
+                </ControlTemplate>
+            </Setter.Value>
+        </Setter>
+    </Style>
+
     <Style x:Key="LabelStyle" TargetType="TextBlock">
         <Setter Property="FontFamily" Value="{StaticResource ArtifaktElementBold}" />
         <Setter Property="FontWeight" Value="Bold" />
@@ -1899,40 +2021,6 @@
         </Setter>
     </Style>
 
-    <!--  Generic Dynamo ToolTip  -->
-    <Style x:Key="GenericToolTipLight" TargetType="ToolTip">
-        <Setter Property="OverridesDefaultStyle" Value="true" />
-        <Setter Property="MaxWidth" Value="300" />
-        <Setter Property="Template">
-            <Setter.Value>
-                <ControlTemplate TargetType="ToolTip">
-                    <Grid x:Name="PopupGrid">
-                        <Grid x:Name="ShadowBackground" Background="Transparent">
-                            <Path Margin="5 0 0 0" Width="20" Height="6" HorizontalAlignment="Left" VerticalAlignment="Top" Data="M0,6 L6,0 12,6Z" Stroke="Gray" Fill="White" Stretch="None" />
-                            <Border BorderThickness="1 0 1 1" CornerRadius="3" Margin="0 5 7 7" BorderBrush="#999999" Background="white" Padding="10,8">
-                                <ContentPresenter/>
-                            </Border>
-                            <Border BorderThickness="0 1 0 0" CornerRadius="0 0 3 0" Margin="16 5 9 0" HorizontalAlignment="Stretch" VerticalAlignment="Top" Height="7" BorderBrush="#999999" />
-                            <Border BorderThickness="0 1 0 0" CornerRadius="3 0 0 0" Margin="0 5 0 0"  HorizontalAlignment="Left" VerticalAlignment="Top" Height="7" Width="6" BorderBrush="#999999" />
-                        </Grid>
-                    </Grid>
-                </ControlTemplate>
-            </Setter.Value>
-        </Setter>
-        <Style.Resources>
-            <Style TargetType="ContentPresenter">
-                <Style.Resources>
-                    <Style TargetType="TextBlock">
-                        <Setter Property="TextWrapping" Value="Wrap" />
-                        <Setter Property="FontFamily" Value="{StaticResource ArtifaktElementRegular}" />
-                        <Setter Property="FontSize" Value="12px" />
-                        <Setter Property="Foreground" Value="#232323" />
-                    </Style>
-                </Style.Resources>
-            </Style>
-        </Style.Resources>
-    </Style>
-
     <Style x:Key="StartPageListBox" TargetType="ListBox">
         <Setter Property="SnapsToDevicePixels" Value="true" />
         <Setter Property="OverridesDefaultStyle" Value="true" />
diff --git a/src/DynamoCoreWpf/ViewModels/PackageManager/PublishPackageViewModel.cs b/src/DynamoCoreWpf/ViewModels/PackageManager/PublishPackageViewModel.cs
index 6d80e49acad..41eb3f584aa 100644
--- a/src/DynamoCoreWpf/ViewModels/PackageManager/PublishPackageViewModel.cs
+++ b/src/DynamoCoreWpf/ViewModels/PackageManager/PublishPackageViewModel.cs
@@ -696,6 +696,40 @@ public PackageUploadRequestBody BaseVersionHeader
             }
         }
 
+        private bool isWarningEnabled;
+        /// <summary>
+        /// This flag will be in true when the Style that user is trying to add already exists (otherwise will be false - Default)
+        /// </summary>
+        public bool IsWarningEnabled
+        {
+            get
+            {
+                return isWarningEnabled;
+            }
+            set
+            {
+                isWarningEnabled = value;
+                RaisePropertyChanged(nameof(IsWarningEnabled));
+            }
+        }
+
+        private string currentWarningMessage;
+        /// <summary>
+        /// This property will hold the warning message that has to be shown in the warning icon next to the TextBox
+        /// </summary>
+        public string CurrentWarningMessage
+        {
+            get
+            {
+                return currentWarningMessage;
+            }
+            set
+            {
+                currentWarningMessage = value;
+                RaisePropertyChanged(nameof(CurrentWarningMessage));
+            }
+        }
+
         #endregion
 
         internal PublishPackageViewModel()
@@ -770,6 +804,8 @@ public PublishPackageViewModel( DynamoViewModel dynamoViewModel ) : this()
         {
             this.dynamoViewModel = dynamoViewModel;
             KnownHosts = initializeHostSelections();
+            //By Default the warning state of the Visual Settings tab (Group Styles section) will be disabled
+            isWarningEnabled = false;
         }
 
         private void ClearAllEntries()
@@ -1723,11 +1759,16 @@ private bool CanPublishLocally()
 
         private bool CheckPackageValidity()
         {
-            if (Name.Contains(@"\") || Name.Contains(@"/") || Name.Contains(@"*"))
+            if (Search.SearchDictionary<object>.ContainsSpecialCharacters(Name))
             {
-                ErrorString = Resources.PackageNameCannotContainTheseCharacters;
+                ErrorString = Resources.PackageNameCannotContainTheseCharacters + " " + new String(Search.SearchDictionary<object>.SpecialAndInvalidCharacters());
+                EnableGroupStyleWarningState(ErrorString);
                 return false;
             }
+            else
+            {
+                IsWarningEnabled = false;
+            }
 
             if (Name.Length < 3)
             {
@@ -1777,6 +1818,15 @@ private bool CheckPackageValidity()
 
             return true;
         }
-    }
 
+        /// <summary>
+        /// This method will enable the warning icon next to the GroupName TextBox and other buttons needed
+        /// </summary>
+        /// <param name="warningMessage">Message that will be displayed when the mouse is over the warning</param>
+        internal void EnableGroupStyleWarningState(string warningMessage)
+        {
+            CurrentWarningMessage = warningMessage;
+            IsWarningEnabled = true;
+        }
+    }
 }
diff --git a/src/DynamoCoreWpf/Views/PackageManager/PublishPackageView.xaml b/src/DynamoCoreWpf/Views/PackageManager/PublishPackageView.xaml
index 81c96039441..0249d177177 100644
--- a/src/DynamoCoreWpf/Views/PackageManager/PublishPackageView.xaml
+++ b/src/DynamoCoreWpf/Views/PackageManager/PublishPackageView.xaml
@@ -31,6 +31,7 @@
                 <ui:SharedResourceDictionary Source="{x:Static ui:SharedDictionaryManager.DynamoColorsAndBrushesDictionaryUri}" />
             </ResourceDictionary.MergedDictionaries>
             <controls:EmptyStringToFalseConverter x:Key="EmptyStringToFalseConverter" />
+            <BooleanToVisibilityConverter x:Key="BooleanToVisibilityConverter"/>
             <ControlTemplate x:Key="ComboBoxToggleButton" TargetType="{x:Type ToggleButton}">
                 <Grid Height="29px"
                       HorizontalAlignment="Stretch"
@@ -419,7 +420,7 @@
                         </TextBlock.ToolTip>
                     </TextBlock>
                     <TextBox Name="packageNameInput"
-                             Style="{StaticResource InputStyle}"
+                             Style="{StaticResource InputStyleWithIcon}"
                              Tag="{x:Static p:Resources.PublishPackageViewPackageNameWatermark}"
                              IsEnabled ="{Binding Path=CanEditName}"
                              Text="{Binding Path=Name, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}"

From 776242cb15de9790255860c673467fe2f04bcfc4 Mon Sep 17 00:00:00 2001
From: jesusalvino <jesus.alvino@globant.com>
Date: Thu, 14 Apr 2022 16:32:20 -0500
Subject: [PATCH 2/9] Updating Warning name and comments

---
 .../ViewModels/PackageManager/PublishPackageViewModel.cs | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/DynamoCoreWpf/ViewModels/PackageManager/PublishPackageViewModel.cs b/src/DynamoCoreWpf/ViewModels/PackageManager/PublishPackageViewModel.cs
index 41eb3f584aa..0f1dcae252b 100644
--- a/src/DynamoCoreWpf/ViewModels/PackageManager/PublishPackageViewModel.cs
+++ b/src/DynamoCoreWpf/ViewModels/PackageManager/PublishPackageViewModel.cs
@@ -698,7 +698,7 @@ public PackageUploadRequestBody BaseVersionHeader
 
         private bool isWarningEnabled;
         /// <summary>
-        /// This flag will be in true when the Style that user is trying to add already exists (otherwise will be false - Default)
+        /// This flag will be in true when the package name is invalid
         /// </summary>
         public bool IsWarningEnabled
         {
@@ -804,7 +804,6 @@ public PublishPackageViewModel( DynamoViewModel dynamoViewModel ) : this()
         {
             this.dynamoViewModel = dynamoViewModel;
             KnownHosts = initializeHostSelections();
-            //By Default the warning state of the Visual Settings tab (Group Styles section) will be disabled
             isWarningEnabled = false;
         }
 
@@ -1762,7 +1761,7 @@ private bool CheckPackageValidity()
             if (Search.SearchDictionary<object>.ContainsSpecialCharacters(Name))
             {
                 ErrorString = Resources.PackageNameCannotContainTheseCharacters + " " + new String(Search.SearchDictionary<object>.SpecialAndInvalidCharacters());
-                EnableGroupStyleWarningState(ErrorString);
+                EnableInvalidNameWarningState(ErrorString);
                 return false;
             }
             else
@@ -1820,10 +1819,10 @@ private bool CheckPackageValidity()
         }
 
         /// <summary>
-        /// This method will enable the warning icon next to the GroupName TextBox and other buttons needed
+        /// This method will enable the warning icon next to the Package Name TextBox
         /// </summary>
         /// <param name="warningMessage">Message that will be displayed when the mouse is over the warning</param>
-        internal void EnableGroupStyleWarningState(string warningMessage)
+        internal void EnableInvalidNameWarningState(string warningMessage)
         {
             CurrentWarningMessage = warningMessage;
             IsWarningEnabled = true;

From 7c4e4ce52f92e4cb2c2335ae8220e3fba6711a34 Mon Sep 17 00:00:00 2001
From: jesusalvino <jesus.alvino@globant.com>
Date: Mon, 18 Apr 2022 14:48:54 -0500
Subject: [PATCH 3/9] Updating the SpecialAndInvalidCharacters function to the
 .Net Library

---
 src/DynamoCore/Search/SearchDictionary.cs | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/src/DynamoCore/Search/SearchDictionary.cs b/src/DynamoCore/Search/SearchDictionary.cs
index 476987cf842..a318a4d84de 100644
--- a/src/DynamoCore/Search/SearchDictionary.cs
+++ b/src/DynamoCore/Search/SearchDictionary.cs
@@ -325,7 +325,23 @@ private static string[] SplitOnWhiteSpace(string s)
 
         public static Char[] SpecialAndInvalidCharacters()
         {
-            return new[] { '*', '.', ' ', '\\', '/', ':', '?', '<', '>', '|', '"' };
+            char[] invalidFileChars = System.IO.Path.GetInvalidFileNameChars();
+
+            List<string> filteredChars = new List<string>();
+            foreach (char someChar in invalidFileChars)
+            {   // Excluding white spaces and uncommon characters, only keeping the displayed in the Windows alert
+                if (!Char.IsWhiteSpace(someChar) && (int)someChar > 31)
+                {
+                    filteredChars.Add(someChar.ToString());
+                }
+            }
+
+            char[] result = new char[filteredChars.Count];
+            for (int i = 0; i < filteredChars.Count; i++)
+            {
+                result[i] = char.Parse(filteredChars[i]);
+            }
+            return result;
         }
 
         public static bool ContainsSpecialCharacters(string element)

From 5df10f12158feb657782e14fad589fba97787350 Mon Sep 17 00:00:00 2001
From: jesusalvino <jesus.alvino@globant.com>
Date: Tue, 19 Apr 2022 10:30:14 -0500
Subject: [PATCH 4/9] Refactoring the SpecialAndInvalidCharacters to single
 line

---
 src/DynamoCore/Search/SearchDictionary.cs | 19 ++-----------------
 1 file changed, 2 insertions(+), 17 deletions(-)

diff --git a/src/DynamoCore/Search/SearchDictionary.cs b/src/DynamoCore/Search/SearchDictionary.cs
index a318a4d84de..3aafc14cb67 100644
--- a/src/DynamoCore/Search/SearchDictionary.cs
+++ b/src/DynamoCore/Search/SearchDictionary.cs
@@ -325,23 +325,8 @@ private static string[] SplitOnWhiteSpace(string s)
 
         public static Char[] SpecialAndInvalidCharacters()
         {
-            char[] invalidFileChars = System.IO.Path.GetInvalidFileNameChars();
-
-            List<string> filteredChars = new List<string>();
-            foreach (char someChar in invalidFileChars)
-            {   // Excluding white spaces and uncommon characters, only keeping the displayed in the Windows alert
-                if (!Char.IsWhiteSpace(someChar) && (int)someChar > 31)
-                {
-                    filteredChars.Add(someChar.ToString());
-                }
-            }
-
-            char[] result = new char[filteredChars.Count];
-            for (int i = 0; i < filteredChars.Count; i++)
-            {
-                result[i] = char.Parse(filteredChars[i]);
-            }
-            return result;
+            // Excluding white spaces and uncommon characters, only keeping the displayed in the Windows alert
+            return System.IO.Path.GetInvalidFileNameChars().Where(x => !char.IsWhiteSpace(x) && (int)x > 31).ToArray();
         }
 
         public static bool ContainsSpecialCharacters(string element)

From 72cdbdc88fc55097fe74b912c37e5c430e4d735c Mon Sep 17 00:00:00 2001
From: jesusalvino <jesus.alvino@globant.com>
Date: Tue, 19 Apr 2022 12:33:13 -0500
Subject: [PATCH 5/9] Updating the accesibility level of the
 SpecialAndInvalidCharacters function

---
 src/DynamoCore/Search/SearchDictionary.cs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/DynamoCore/Search/SearchDictionary.cs b/src/DynamoCore/Search/SearchDictionary.cs
index 3aafc14cb67..00e676e2cf3 100644
--- a/src/DynamoCore/Search/SearchDictionary.cs
+++ b/src/DynamoCore/Search/SearchDictionary.cs
@@ -323,7 +323,7 @@ private static string[] SplitOnWhiteSpace(string s)
             return s.Split(null);
         }
 
-        public static Char[] SpecialAndInvalidCharacters()
+        internal static Char[] SpecialAndInvalidCharacters()
         {
             // Excluding white spaces and uncommon characters, only keeping the displayed in the Windows alert
             return System.IO.Path.GetInvalidFileNameChars().Where(x => !char.IsWhiteSpace(x) && (int)x > 31).ToArray();

From e864e85d27f2dd59c488eaf92338f37c06cc70d3 Mon Sep 17 00:00:00 2001
From: jesusalvino <jesus.alvino@globant.com>
Date: Tue, 19 Apr 2022 16:02:12 -0500
Subject: [PATCH 6/9] Using the SpecialAndInvalidCharacters as a static
 property

---
 src/DynamoCore/Configuration/PathManager.cs   | 23 +++++++++++++++++++
 src/DynamoCore/Search/SearchDictionary.cs     |  8 +------
 .../PackageManager/PublishPackageViewModel.cs |  4 ++--
 3 files changed, 26 insertions(+), 9 deletions(-)

diff --git a/src/DynamoCore/Configuration/PathManager.cs b/src/DynamoCore/Configuration/PathManager.cs
index b3a34562a26..42f2dc76e7d 100644
--- a/src/DynamoCore/Configuration/PathManager.cs
+++ b/src/DynamoCore/Configuration/PathManager.cs
@@ -131,6 +131,29 @@ internal static string BuiltinPackagesDirectory
             }
         }
 
+        private static char[] invalidCharacters = null;
+        /// <summary>
+        /// List of the Windows invalid characters
+        /// </summary>
+        internal static char[] InvalidCharacters
+        {
+            get
+            {
+                if (invalidCharacters == null)
+                {
+                    invalidCharacters = Search.SearchDictionary<object>.SpecialAndInvalidCharacters();
+                }
+                return invalidCharacters;
+            }
+            set
+            {
+                if (invalidCharacters != value)
+                {
+                    invalidCharacters = value;
+                }
+            }
+        }
+
         //Todo in Dynamo 3.0, Add this to the IPathManager interface
         /// <summary>
         /// The local directory that contains package directory created by all users.
diff --git a/src/DynamoCore/Search/SearchDictionary.cs b/src/DynamoCore/Search/SearchDictionary.cs
index 00e676e2cf3..06eb3b05e58 100644
--- a/src/DynamoCore/Search/SearchDictionary.cs
+++ b/src/DynamoCore/Search/SearchDictionary.cs
@@ -327,13 +327,7 @@ internal static Char[] SpecialAndInvalidCharacters()
         {
             // Excluding white spaces and uncommon characters, only keeping the displayed in the Windows alert
             return System.IO.Path.GetInvalidFileNameChars().Where(x => !char.IsWhiteSpace(x) && (int)x > 31).ToArray();
-        }
-
-        public static bool ContainsSpecialCharacters(string element)
-        {
-            Char[] invalidCharacters = SpecialAndInvalidCharacters();
-            return (!string.IsNullOrEmpty(element) && element.IndexOfAny(invalidCharacters) >= 0);
-        }
+        }        
 
         #endregion
 
diff --git a/src/DynamoCoreWpf/ViewModels/PackageManager/PublishPackageViewModel.cs b/src/DynamoCoreWpf/ViewModels/PackageManager/PublishPackageViewModel.cs
index 0f1dcae252b..b4a81eaa0c4 100644
--- a/src/DynamoCoreWpf/ViewModels/PackageManager/PublishPackageViewModel.cs
+++ b/src/DynamoCoreWpf/ViewModels/PackageManager/PublishPackageViewModel.cs
@@ -1758,9 +1758,9 @@ private bool CanPublishLocally()
 
         private bool CheckPackageValidity()
         {
-            if (Search.SearchDictionary<object>.ContainsSpecialCharacters(Name))
+            if (!string.IsNullOrEmpty(Name) && Name.IndexOfAny(PathManager.InvalidCharacters) >= 0)
             {
-                ErrorString = Resources.PackageNameCannotContainTheseCharacters + " " + new String(Search.SearchDictionary<object>.SpecialAndInvalidCharacters());
+                ErrorString = Resources.PackageNameCannotContainTheseCharacters + " " + new String(PathManager.InvalidCharacters);
                 EnableInvalidNameWarningState(ErrorString);
                 return false;
             }

From 52159ca6e2246cba31f8f5dc6aa6e97bb063cbd5 Mon Sep 17 00:00:00 2001
From: jesusalvino <jesus.alvino@globant.com>
Date: Wed, 20 Apr 2022 10:57:47 -0500
Subject: [PATCH 7/9] Restoring the function ContainsSpecialCharacters for
 testing purpose

---
 src/DynamoCore/Search/SearchDictionary.cs | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/DynamoCore/Search/SearchDictionary.cs b/src/DynamoCore/Search/SearchDictionary.cs
index 06eb3b05e58..31aa5bf3dc2 100644
--- a/src/DynamoCore/Search/SearchDictionary.cs
+++ b/src/DynamoCore/Search/SearchDictionary.cs
@@ -327,7 +327,13 @@ internal static Char[] SpecialAndInvalidCharacters()
         {
             // Excluding white spaces and uncommon characters, only keeping the displayed in the Windows alert
             return System.IO.Path.GetInvalidFileNameChars().Where(x => !char.IsWhiteSpace(x) && (int)x > 31).ToArray();
-        }        
+        }
+
+        private static bool ContainsSpecialCharacters(string element)
+        {
+            Char[] invalidCharacters = SpecialAndInvalidCharacters();
+            return (!string.IsNullOrEmpty(element) && element.IndexOfAny(invalidCharacters) >= 0);
+        }
 
         #endregion
 

From e877a2c081bf90ca8b49185bce532144fbfa62cd Mon Sep 17 00:00:00 2001
From: jesusalvino <jesus.alvino@globant.com>
Date: Wed, 20 Apr 2022 12:23:44 -0500
Subject: [PATCH 8/9] Moving the place of the SpecialAndInvalidCharacters

---
 src/DynamoCore/Configuration/PathManager.cs |  2 +-
 src/DynamoCore/Search/SearchDictionary.cs   | 11 +++--------
 src/DynamoUtilities/PathHelper.cs           |  6 ++++++
 3 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/src/DynamoCore/Configuration/PathManager.cs b/src/DynamoCore/Configuration/PathManager.cs
index 42f2dc76e7d..3271ec31a12 100644
--- a/src/DynamoCore/Configuration/PathManager.cs
+++ b/src/DynamoCore/Configuration/PathManager.cs
@@ -141,7 +141,7 @@ internal static char[] InvalidCharacters
             {
                 if (invalidCharacters == null)
                 {
-                    invalidCharacters = Search.SearchDictionary<object>.SpecialAndInvalidCharacters();
+                    invalidCharacters = PathHelper.SpecialAndInvalidCharacters();
                 }
                 return invalidCharacters;
             }
diff --git a/src/DynamoCore/Search/SearchDictionary.cs b/src/DynamoCore/Search/SearchDictionary.cs
index 31aa5bf3dc2..b497948aecc 100644
--- a/src/DynamoCore/Search/SearchDictionary.cs
+++ b/src/DynamoCore/Search/SearchDictionary.cs
@@ -5,6 +5,7 @@
 using System.Linq;
 using System.Diagnostics;
 using Dynamo.Configuration;
+using DynamoUtilities;
 
 namespace Dynamo.Search
 {
@@ -321,17 +322,11 @@ private static Dictionary<V, double> MatchWithSubset(Dictionary<V,double> search
         private static string[] SplitOnWhiteSpace(string s)
         {
             return s.Split(null);
-        }
-
-        internal static Char[] SpecialAndInvalidCharacters()
-        {
-            // Excluding white spaces and uncommon characters, only keeping the displayed in the Windows alert
-            return System.IO.Path.GetInvalidFileNameChars().Where(x => !char.IsWhiteSpace(x) && (int)x > 31).ToArray();
-        }
+        }        
 
         private static bool ContainsSpecialCharacters(string element)
         {
-            Char[] invalidCharacters = SpecialAndInvalidCharacters();
+            Char[] invalidCharacters = PathHelper.SpecialAndInvalidCharacters();
             return (!string.IsNullOrEmpty(element) && element.IndexOfAny(invalidCharacters) >= 0);
         }
 
diff --git a/src/DynamoUtilities/PathHelper.cs b/src/DynamoUtilities/PathHelper.cs
index fdd4f6e833c..e88dae0ba6b 100644
--- a/src/DynamoUtilities/PathHelper.cs
+++ b/src/DynamoUtilities/PathHelper.cs
@@ -246,5 +246,11 @@ public static void FileInfoAtPath(string path, out bool fileExists, out string s
                 size = string.Empty;
             }
         }
+
+        internal static Char[] SpecialAndInvalidCharacters()
+        {
+            // Excluding white spaces and uncommon characters, only keeping the displayed in the Windows alert
+            return System.IO.Path.GetInvalidFileNameChars().Where(x => !char.IsWhiteSpace(x) && (int)x > 31).ToArray();
+        }
     }
 }

From 250989e2f52dcc13cbddbbeaa6b2fd5484020ca1 Mon Sep 17 00:00:00 2001
From: jesusalvino <jesus.alvino@globant.com>
Date: Wed, 20 Apr 2022 14:33:40 -0500
Subject: [PATCH 9/9] Removing the InvalidCharacters static property

---
 src/DynamoCore/Configuration/PathManager.cs   | 23 -------------------
 .../PackageManager/PublishPackageViewModel.cs |  5 ++--
 2 files changed, 3 insertions(+), 25 deletions(-)

diff --git a/src/DynamoCore/Configuration/PathManager.cs b/src/DynamoCore/Configuration/PathManager.cs
index 3271ec31a12..b3a34562a26 100644
--- a/src/DynamoCore/Configuration/PathManager.cs
+++ b/src/DynamoCore/Configuration/PathManager.cs
@@ -131,29 +131,6 @@ internal static string BuiltinPackagesDirectory
             }
         }
 
-        private static char[] invalidCharacters = null;
-        /// <summary>
-        /// List of the Windows invalid characters
-        /// </summary>
-        internal static char[] InvalidCharacters
-        {
-            get
-            {
-                if (invalidCharacters == null)
-                {
-                    invalidCharacters = PathHelper.SpecialAndInvalidCharacters();
-                }
-                return invalidCharacters;
-            }
-            set
-            {
-                if (invalidCharacters != value)
-                {
-                    invalidCharacters = value;
-                }
-            }
-        }
-
         //Todo in Dynamo 3.0, Add this to the IPathManager interface
         /// <summary>
         /// The local directory that contains package directory created by all users.
diff --git a/src/DynamoCoreWpf/ViewModels/PackageManager/PublishPackageViewModel.cs b/src/DynamoCoreWpf/ViewModels/PackageManager/PublishPackageViewModel.cs
index b4a81eaa0c4..81d9313675a 100644
--- a/src/DynamoCoreWpf/ViewModels/PackageManager/PublishPackageViewModel.cs
+++ b/src/DynamoCoreWpf/ViewModels/PackageManager/PublishPackageViewModel.cs
@@ -18,6 +18,7 @@
 using Dynamo.ViewModels;
 using Dynamo.Wpf.Properties;
 using Dynamo.Wpf.Utilities;
+using DynamoUtilities;
 using Greg.Requests;
 using Microsoft.Practices.Prism.Commands;
 using PythonNodeModels;
@@ -1758,9 +1759,9 @@ private bool CanPublishLocally()
 
         private bool CheckPackageValidity()
         {
-            if (!string.IsNullOrEmpty(Name) && Name.IndexOfAny(PathManager.InvalidCharacters) >= 0)
+            if (!string.IsNullOrEmpty(Name) && Name.IndexOfAny(PathHelper.SpecialAndInvalidCharacters()) >= 0)
             {
-                ErrorString = Resources.PackageNameCannotContainTheseCharacters + " " + new String(PathManager.InvalidCharacters);
+                ErrorString = Resources.PackageNameCannotContainTheseCharacters + " " + new String(PathHelper.SpecialAndInvalidCharacters());
                 EnableInvalidNameWarningState(ErrorString);
                 return false;
             }