Clean-up of DynamoModel.ShutDown methods #2436
Conversation
| @@ -676,7 +676,10 @@ void Instance_UpdateDownloaded(object sender, UpdateManager.UpdateDownloadedEven | |||
|
|
|||
| void updateManager_ShutdownRequested(object sender, EventArgs e) | |||
| { | |||
| Exit(true, true); | |||
| if (SetAllowCancelAndRequestUIClose(true)) | |||
There was a problem hiding this comment.
Does this need the EventArgs argument too? Looks like it does not, in which case the ShutdownRequestedEventHandler delegate signature can be changed as well.
There was a problem hiding this comment.
That's a good point, let me fix that.
|
@Benglin aside from that one comment, the rest of it looks good. Thanks. |
| @@ -49,6 +49,16 @@ public RevitVisualizationManager(DynamoModel dynamoModel) : base(dynamoModel) | |||
|
|
|||
| private void CleanupVisualizations(object sender, EventArgs e) | |||
| { | |||
There was a problem hiding this comment.
Have you not gotten rid of this function signature: private void CleanupVisualizations(object sender, EventArgs e)?
There was a problem hiding this comment.
Unfortunately that is required by another RequestAlternateContextClear, which I cannot changed (due to it being defined as a EventHandler). That's why I moved the common bits out into the parameterless CleanupVisualizations below.
|
Thanks @aparajit-pratap for reviewing it. I have made the suggested changes, please have a go at it again. |
|
LGTM |
Clean-up of DynamoModel.ShutDown methods
Hi @aparajit-pratap, this is a minor clean-up as part of another larger change. It removes unused
EventArgsfromDynamoModel.ShutDownandRevitDynamoModel.ShutDownmethods (also some downstream methods).Please have a look, thanks!
P/S: As this is related to Revit, I will also merge these changes into
Revit2015when you're done.