Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request/Proposal] Setting for Arbitrary 86Box Location #3

Open
sedme0 opened this issue May 20, 2023 · 1 comment
Open

[Feature Request/Proposal] Setting for Arbitrary 86Box Location #3

sedme0 opened this issue May 20, 2023 · 1 comment

Comments

@sedme0
Copy link

sedme0 commented May 20, 2023

I think that the combobox to select which copy of 86Box to use is a bad idea. It's too restrictive regarding where the binary is located. If a user's distro doesn't have a package for 86Box (like Debian), then they're required to use the flatpak, and that's not something that everyone (myself included) is willing to do. My quick and dirty solution was to edit lines 95 and 97 of linbox.py so instead of /usr/bin/86Box, it's /home/sedme/programs-src/86Box/build/artifacts/bin/86Box, which is where my copy of 86Box is located. For a more permanent solution, I propose the following:

First, gut the combobox and everything related to it. Make it so that the location of the binary is a single variable, whose value is stored in Linbox.ini. Then, add an interface that allows the user to change this value within Linbox. I envision a button that you click, which opens a pop-up window that tells the user to select the location of the 86Box binary. This window would show a list of detected binaries. It would detect these binaries by checking every directory in the user's PATH, and maybe some other common locations as well. Underneath the list would be a text entry box where the raw text of a location could be entered. So, when you click on an item in the list, it would highlight and put it into the text entry box. There would also be a button, either at the end of the list or next to the text entry box, which would open the file select dialog, so the user could select it that way.

If you want, I could program such a feature myself. I would've just gone ahead and done it without asking, but I'd like to make sure that this effort would actually be appreciated first.

Also, this is unrelated, but when logging executed commands to the console, you probably shouldn't use .toupper() on them, since they're case-sensitive. If you really want to give them some formatting so they stand out, I recommend changing their color.

@Dungeonseeker
Copy link
Owner

Hi, apologies for the delay, I've been away. Let me get settled in tonight and I'll get back to you tomorrow. I'm always open to suggestions and will merge requests I feel are beneficial. If you wanna create a fork and sumbit a PR go right ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants