Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add tailwind code for gradient text generator #411

Closed
2 of 4 tasks
Dun-sin opened this issue Jul 21, 2023 · 9 comments · Fixed by #427
Closed
2 of 4 tasks

[FEATURE] Add tailwind code for gradient text generator #411

Dun-sin opened this issue Jul 21, 2023 · 9 comments · Fixed by #427
Assignees
Labels
assigned Issue is no longer available for anyone else to work on EddieHub:good-first-issue feature good first issue Good for newcomers released

Comments

@Dun-sin
Copy link
Owner

Dun-sin commented Jul 21, 2023

Description

The button has been added to copy tailwind code, but it doesn't have the actual code added to it, the tasks:

  • Add tailwind equivalent code for the gradient text (all you need to do is actually convert the CSS
    p{
    font-size: ${(outputElement.children[0] as HTMLElement).style.fontSize};
    background: ${
    (outputElement.children[0] as HTMLElement).style.background
    };
    background-clip: text;
    -webkit-background-clip: text;
    -webkit-text-fill-color: transparent;
    }
    to Tailwind and add it to the appropriate case here ->
    const actOnTailwindGenerator = (attribute: string) => {
    )
  • Test that it works with tailwind

Screenshots

No response

Additional information

If you notice any change you want to add, not related to this Issue, please raise an issue for it instead of adding it to the PR

👀 Have you checked if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

None

@Dun-sin Dun-sin added feature up for grabs Issue is still available for anyone to work on labels Jul 21, 2023
@github-actions
Copy link

It's great having you contribute to this project by creating an issue

Make sure you are assigned to this before you work on it and you read the Contributing.md file, Thank you! Welcome to the community 🤓

@aqsaaqeel
Copy link
Contributor

Can i work on this?

@Dun-sin Dun-sin assigned aqsaaqeel and unassigned aqsaaqeel Jul 29, 2023
@Dun-sin
Copy link
Owner Author

Dun-sin commented Jul 29, 2023

Can i work on this?

Actually no, your last issue needs to have a PR to it, that should be merged and closed. You can't work on two at the same time.

@matthiasmulzet
Copy link
Contributor

Hello, can i work on this ?

@Dun-sin
Copy link
Owner Author

Dun-sin commented Jul 29, 2023

Hello, can i work on this ?

Definitely, thanks for wanting to contribute, Make sure you follow the rules 👉🏽here👈🏽, else your PR will not be accepted and will be closed.
Good Luck

@Dun-sin Dun-sin added assigned Issue is no longer available for anyone else to work on and removed up for grabs Issue is still available for anyone to work on labels Jul 29, 2023
@matthiasmulzet
Copy link
Contributor

that the Tailwind copy function works, it is neccessary to add the outputElement: HTMLElement to the copyTailwindCodeToClipboard and the actOnTailwindGenerator function. Should i create an own issue for that? Or should i only add the Tailwind code to the actOnTailwindGenerator function?

@Dun-sin
Copy link
Owner Author

Dun-sin commented Jul 30, 2023

that the Tailwind copy function works, it is neccessary to add the outputElement: HTMLElement to the copyTailwindCodeToClipboard and the actOnTailwindGenerator function. Should i create an own issue for that? Or should i only add the Tailwind code to the actOnTailwindGenerator function?

Yes the function works just but what it copies is empty, and yes just add the necessary but make the argument for outputElement optional using(?)

@Dun-sin
Copy link
Owner Author

Dun-sin commented Jul 30, 2023

@matthiasmulzet actually the current update has added the outputElement as an optional argument already, you need to do a git pull from main, so you can just add the Tailwind code

@Dun-sin
Copy link
Owner Author

Dun-sin commented Aug 6, 2023

🎉 This issue has been resolved in version 2.60.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned Issue is no longer available for anyone else to work on EddieHub:good-first-issue feature good first issue Good for newcomers released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants