Fix #692 pfp edit button placement #734
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| > | ||
| <span class="i-mdi-edit" /> | ||
| <span class="i-mdi-edit absolute bottom-[0.6rem] right-[0.6rem]" /> |
There was a problem hiding this comment.
Thanks for fixing this! Some comments/thoughts:
I think we should try to use the built-in "sizes" as much as possible, for example bottom-2 is the same as bottom-[0.5rem].
Also, can't this be centered?
And lastly, since you're a developer you don't need to work from a fork! You can create branches in the main repo directly :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the edit button to the bottom right corner of the profile pic and made it circular.