-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hot reloading is not working #3
Comments
You might have seen this posts, still just for your info. I found hot reloading most of the time is broken and I had lost confidence in it and reload all the time. Dan also had few posts about it, and not sure just using plain webpack HMR is better. https://medium.com/@dan_abramov/hot-reloading-in-react-1140438583bf#.somfrw9yk
Dan made an update to this post about ver 3
not released yet and not sure the plans. this pull request has few boilerplates with react hot boilerplate 3, like |
sorry, just saw you uses react-hot-loader@3.0.0-beta.2 . so, indeed you are aware :-) |
Thanks for your efforts. I have broken hot reloading with the async loading of components in the routes. I think i just have to require all route components in development mode and load them async in production mode. Had no time to try that out. react-hot-loader cannot load modules async right now. |
thanks. I too not in quite need of it now. today was migrating my project to use all the goodies from your setup. thanks again for sharing it. |
Hi. I tried to implement it based on this boilerplate https://github.com/mgcrea/react-webpack-factory I tried with wrapping the root component in
I tried with just for your info, and you may find some ideas from this repo. |
@bsr thanks for your effort in this. I played around a bit and found out that i had 2 issues that prevented react-hot-reloader from working:
i fixed booth problems in 9b2fdb4. Hope that was all, but it seems to be woking |
great to hear it is working. I don't use dynamic loading and could make it work with help from some other repo. will find it out if you need a reference. But, I see only |
things are moving crazy in JS land :-) now I am making snapshot testing to work properly |
@bsr yeah i edited the message ;D There was a wrong commit hash in it ;D |
@bsr i will take a look into snapshot testing. Don't know about it yet :) |
there is a live session by the author in about 2 hrs, if you are interested,https://www.facebook.com/events/285156468510102/?active_tab=posts |
@bsr203 cool thanks for the link |
Hot reloading of components is broken right now, though Styles will update correctly.
The text was updated successfully, but these errors were encountered: