Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SA1623 code fix throws exception for empty summary #1943

Closed
sharwell opened this issue Dec 10, 2015 · 4 comments
Closed

SA1623 code fix throws exception for empty summary #1943

sharwell opened this issue Dec 10, 2015 · 4 comments
Assignees
Milestone

Comments

@sharwell
Copy link
Member

The code fix for SA1623 throws an exception when attempting to fix the following code:

public class ClassName
{
    /// <summary></summary>
    public int Property
    {
        get;
    }
}
@sharwell sharwell added this to the 1.0.0 milestone Dec 10, 2015
@NikolayIT
Copy link
Member

@sharwell, What should the code fix do when given empty summary?

I am suggesting replacing the code with

public class ClassName
{
    /// <summary>Gets Property</summary>
    public int Property
    {
        get;
    }
}

@sharwell
Copy link
Member Author

What should the code fix do when given empty summary?

I vote for nothing at all.

@NikolayIT
Copy link
Member

@sharwell doing nothing will leave the warning 😄

@sharwell
Copy link
Member Author

Yes, the warning would remain because this is a situation where we cannot provide a meaningful code fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants