Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update using directive code fix to support blank lines between groups #1787

Closed
sharwell opened this issue Nov 18, 2015 · 4 comments
Closed
Assignees
Milestone

Comments

@sharwell
Copy link
Member

As mentioned by @vweijsters during code review in #1785:

We [should] also add a setting that will insert blank lines between the top-level groups, as described in CoreFx coding guidelines point 6.

Marking as needs discussion since this will require a new configuration property which we haven't named yet.

Edit: Rule SA1516 would be updated to report violations according to this setting. The supported values would be allow (default), require, and omit, just like we implemented for a similar situation in #1820.

@sharwell
Copy link
Member Author

sharwell commented Dec 7, 2015

I'm marking this as a proposal based on my edit in the original comment.

My vote is 👍

@vweijsters I deleted your 👍 comment since the meaning of this issue changed.

@rkeithhill
Copy link

Yes, please make this change to better support the CoreFx coding guidelines.

@vweijsters
Copy link
Contributor

👍 (including the edit)

@sharwell sharwell modified the milestones: Backlog, 1.1.0 Dec 17, 2015
@vweijsters
Copy link
Contributor

Grabbing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants