Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot_dependencies() doesn't work with the latest {igraph} #51

Closed
IndrajeetPatil opened this issue Feb 12, 2023 · 3 comments
Closed

plot_dependencies() doesn't work with the latest {igraph} #51

IndrajeetPatil opened this issue Feb 12, 2023 · 3 comments
Assignees
Labels
bug 💣 Bug to fix short term ⏰ TODO short term

Comments

@IndrajeetPatil
Copy link

Looks like {igraph} update on CRAN has broken {deepdep}:

https://cran.rstudio.com/web/checks/check_results_deepdep.html

@szhorvat
Copy link

This is due to the intentional breaking change noted in igraph's NEWS file:

https://cran.r-project.org/web/packages/igraph/news/news.html

When setting vertex or edge attributes, the number of values supplied must now exactly match the number of vertices or edges.

Previously, recycling was used to fill out the missing elements.

@ErdaradunGaztea ErdaradunGaztea added bug 💣 Bug to fix short term ⏰ TODO short term labels Feb 12, 2023
@ErdaradunGaztea ErdaradunGaztea added this to the deepdep v0.4.2 milestone Feb 12, 2023
@ErdaradunGaztea
Copy link
Collaborator

Ooops! Thanks for the details, sounds like we have some bad coding practices on our hands.

@DominikRafacz DominikRafacz self-assigned this Feb 20, 2023
@DominikRafacz
Copy link
Owner

This issue is closed in 0.4.2 version. It has already been submitted to CRAN, should be published soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 💣 Bug to fix short term ⏰ TODO short term
Projects
None yet
Development

No branches or pull requests

4 participants