[Qual] Suspicious passing of list called 'variations' to 'combinations' argument and not 'variations'.

[mdeweerd]

Bug

Phan report:

Warning: ProductCombination.class.php: PhanPluginSuspiciousParamPosition: Suspicious order for argument variations - This is getting passed to parameter #4 (array $variations) of \ProductCombination::createProductCombination(\User $user, \Product $product, array $combinations, array $variations, array|bool $price_var_percent = false, bool|float $forced_pricevar = false, bool|float $forced_weightvar = false, bool|string $forced_refvar = false, string $ref_ext = '') defined at htdocs/variants/class/ProductCombination.class.php:716

Code:

dolibarr/htdocs/variants/class/ProductCombination.class.php

Lines 951 to 965 in f45f5c3

	foreach ($combinations as $combination) {
	$variations = array();
	foreach ($prodcomb2val->fetchByFkCombination($combination->id) as $tmp_pc2v) {
	$variations[$tmp_pc2v->fk_prod_attr] = $tmp_pc2v->fk_prod_attr_val;
	}
	if ($this->createProductCombination(
	$user,
	$destProduct,
	$variations,
	array(),
	$combination->variation_price_percentage,
	$combination->variation_price,
	$combination->variation_weight

It does look suspicious to create contents for a list called $variations from a list called $combinations and then pass $variations to the method's argument called combinations instead of passing it to variations.

Environment Version

At least 16.0 up to develop included

Environment OS

No response

Environment Web server

No response

Environment PHP

No response

Environment Database

No response

Environment URL(s)

No response

Expected and actual behavior

No response

Steps to reproduce the behavior

No response

Attached files

No response