Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle aliases with has_attributes #93

Merged
merged 3 commits into from
Apr 21, 2021
Merged

Handle aliases with has_attributes #93

merged 3 commits into from
Apr 21, 2021

Conversation

Zooip
Copy link
Contributor

@Zooip Zooip commented Apr 20, 2021 •
edited
Loading

Change StoreModel::Model#has_attribute? to respond true on aliased attributes.

The same changes were made on Rails 6.1 :

@DmitryTsepelev
Copy link
Owner

LGTM, thanks!

@DmitryTsepelev DmitryTsepelev merged commit 49fa1c8 into DmitryTsepelev:master Apr 21, 2021
@Zooip Zooip deleted the has_attribute_alias branch July 8, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zooip @DmitryTsepelev