Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly compare enum attributes in Model#== #29

Merged
merged 1 commit into from
Aug 23, 2019
Merged

Properly compare enum attributes in Model#== #29

merged 1 commit into from
Aug 23, 2019

Conversation

DmitryTsepelev
Copy link
Owner

No description provided.

@DmitryTsepelev DmitryTsepelev mentioned this pull request Aug 23, 2019
Closed
@FunkyloverOne
Copy link

Looks good to me, thanks!

However, I don't understand why are you using truthy/falsey checks in your tests, where you know it should be exactly true or false.

@DmitryTsepelev
Copy link
Owner Author

Yep, using be false sounds reasonable. Merging it in when specs pass

@DmitryTsepelev DmitryTsepelev merged commit 71c147e into master Aug 23, 2019
@DmitryTsepelev DmitryTsepelev deleted the compare-models-with-enums branch August 23, 2019 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DmitryTsepelev @FunkyloverOne