Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't add _entities or _Entity when no @key types exist in the schema #8

Closed
kdawgwilk opened this issue Jul 14, 2021 · 1 comment
Closed

Don't add _entities or _Entity when no @key types exist in the schema #8

kdawgwilk opened this issue Jul 14, 2021 · 1 comment
Assignees
@kdawgwilk

Comments

@kdawgwilk
Copy link
Collaborator

There is an issue with absinthe that renders unions with no types in a non-spec compliance way e.g.

union _Entity =

We should just not add this type to the schema if there are no types marked as @key(fields: "") found in the schema during our processing phase to workaround this absinthe issue. There is a PR to fix this in absinthe but the GraphQL spec contradicts itself by saying the types are optional but in the validation docs it says a union must have at least one type
@kdawgwilk kdawgwilk self-assigned this Jul 14, 2021
@kdawgwilk kdawgwilk mentioned this issue Jul 15, 2021
Closed
@kdawgwilk
Copy link
Collaborator Author

This was addressed in absinthe-graphql/absinthe#1085 and was released in 1.6.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kdawgwilk kdawgwilk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't add _Entity/_entities when no @key types found DivvyPayHQ/absinthe_federation
1 participant
@kdawgwilk