Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat(default-theme): add subcat in mobile nav #944

Merged
merged 10 commits into from
Jul 27, 2020
Merged

feat(default-theme): add subcat in mobile nav #944

merged 10 commits into from
Jul 27, 2020

Conversation

Malwurf
Copy link
Collaborator

@Malwurf Malwurf commented Jul 13, 2020 •
edited
Loading

Changes

closes #862

Checklist

@vercel
Copy link

vercel bot commented Jul 13, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/ny5obovau
✅ Preview: In Progress

(2898aac, update in progress)

@github-actions
Copy link

github-actions bot commented Jul 13, 2020 •
edited
Loading

💙 shopware-pwa-canary successfully deployed at https://ede45a75a0a3c1e7b0f9077b031d499d24e0d461.shopware-pwa-canary.preview.storefrontcloud.io

@vercel vercel bot temporarily deployed to preview July 14, 2020 09:08 Inactive
@vercel vercel bot temporarily deployed to preview July 14, 2020 13:39 Inactive
@vercel vercel bot temporarily deployed to preview July 16, 2020 13:43 Inactive
@vercel vercel bot temporarily deployed to Preview July 17, 2020 11:21 Inactive
@vercel vercel bot temporarily deployed to preview July 17, 2020 11:21 Inactive
akrajna
akrajna suggested changes Jul 20, 2020
View reviewed changes
Copy link
Collaborator

@akrajna akrajna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. the bottom menu should close after clicking outside of its area
    MobileSubcategoriesMenu
  2. the bottom menu opens after pressing my account or home button. It should not open when user is trying to go to his account or going back to home page.
    MobileSubcategoriesMenuHomeAccount

@vercel vercel bot temporarily deployed to preview July 22, 2020 09:52 Inactive
@Malwurf Malwurf requested a review from akrajna July 22, 2020 09:59
@Malwurf Malwurf marked this pull request as ready for review July 22, 2020 10:07
akrajna
akrajna reviewed Jul 22, 2020
View reviewed changes
Copy link
Collaborator

@akrajna akrajna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine

@vercel vercel bot temporarily deployed to preview July 27, 2020 07:39 Inactive
@patzick patzick merged commit 4037876 into master Jul 27, 2020
@patzick patzick deleted the feature/mobile-submenu-#862 branch July 27, 2020 07:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akrajna akrajna akrajna requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Submenu on mobile
3 participants
@Malwurf @akrajna @patzick