Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

fix: only count products in cart #908 #909

Merged
merged 4 commits into from
Jul 21, 2020
Merged

fix: only count products in cart #908 #909

merged 4 commits into from
Jul 21, 2020

Conversation

mmeester
Copy link
Contributor

@mmeester mmeester commented Jul 1, 2020

Changes

closes: #908

Checklist

@vercel
Copy link

vercel bot commented Jul 1, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/nc0qhgip9
✅ Preview: https://shopware-pwa-docs-git-fork-mmeester-fix-cart-count-items-908.shopware-pwa.vercel.app

@vercel vercel bot temporarily deployed to preview July 1, 2020 09:06 Inactive
@vercel vercel bot temporarily deployed to preview July 10, 2020 08:53 Inactive
@patzick
Copy link
Collaborator

patzick commented Jul 10, 2020

hey @mmeester thanks, good point with that issue, we just aim to have 100% tests coverage, but here tests are failing. Could you fix that? :)
you need to run yarn test and it will show you tests result and coverage

@vercel vercel bot temporarily deployed to preview July 21, 2020 13:49 Inactive
@vercel vercel bot temporarily deployed to preview July 21, 2020 14:01 Inactive
@patzick patzick merged commit 6e4bb5a into vuestorefront:master Jul 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [OR UNWANTED FEATURE] the count of the cart also shows discount items
2 participants