Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat: add home path in breadcrumb #905

Merged

Conversation

luklus
Copy link
Contributor

@luklus luklus commented Jun 30, 2020

Changes

closes #846

Zrzut ekranu z 2020-06-30 14-26-18

Checklist

@vercel
Copy link

vercel bot commented Jun 30, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/qv4t258dc
✅ Preview: In Progress

(d9caa1c, update in progress)

@vercel vercel bot temporarily deployed to preview June 30, 2020 12:37 Inactive
@github-actions
Copy link

github-actions bot commented Jun 30, 2020

💙 shopware-pwa-canary successfully deployed at https://d5ef8e5855407f049b2abe4a08d56422d892ce9f.shopware-pwa-canary.preview.storefrontcloud.io

Copy link
Collaborator

@akrajna akrajna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • breadcrumbs in checkout depends on from which page user enter the checkout e.g.
    • if user was on home page before enter checkout - there is no breadcrumbs at all
    • if user was on 'Women' category before enter checkout - there is 'HOME-WOMEN' breadcrumbs
      Breadcrumbs-checkout
  • there is no breadcrumbs on product detail page:

Breadcrumbs-Product-Page

  • there is no breadcrumbs on 'my account' page

breadcrumbs-myaccount

@luklus
Copy link
Contributor Author

luklus commented Jul 1, 2020

@akrajna there is no breadcrumbs on product detail page, there is no breadcrumbs on 'my account' page - https://github.com/DivanteLtd/shopware-pwa/projects/15#card-41063261

@luklus
Copy link
Contributor Author

luklus commented Jul 1, 2020

@akrajna breadcrumbs in checkout depends on from which page user enter the checkout e.g - no breadcrumbs on checkout page

@vercel vercel bot temporarily deployed to preview July 1, 2020 09:10 Inactive
@akrajna
Copy link
Collaborator

akrajna commented Jul 1, 2020

Works fine. As discussed there are breadcrumbs on categories page and checkout, we will work on breadcrumbs on product page.

@vercel vercel bot temporarily deployed to preview July 1, 2020 10:10 Inactive
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to have i18n here, please add this for English and German language, so after the language change there will be a difference to see


if (breadcrumbs.length > 0) {
breadcrumbs.unshift({
text: "Home",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not meet Acceptance criterium:
Text editable through i18n

@vercel vercel bot temporarily deployed to preview July 1, 2020 13:07 Inactive
@vercel vercel bot temporarily deployed to preview July 6, 2020 15:34 Inactive
@patzick patzick merged commit f95fcff into master Jul 6, 2020
@patzick patzick deleted the feat(default-theme)/Breadcrumbs-include-a-home-button-#846 branch July 6, 2020 15:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Breadcrumbs include a home-button
3 participants