-
Notifications
You must be signed in to change notification settings - Fork 103
feat: add home path in breadcrumb #905
feat: add home path in breadcrumb #905
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/qv4t258dc (d9caa1c, update in progress) |
💙 shopware-pwa-canary successfully deployed at https://d5ef8e5855407f049b2abe4a08d56422d892ce9f.shopware-pwa-canary.preview.storefrontcloud.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- breadcrumbs in checkout depends on from which page user enter the checkout e.g.
- there is no breadcrumbs on product detail page:
- there is no breadcrumbs on 'my account' page
@akrajna there is no breadcrumbs on product detail page, there is no breadcrumbs on 'my account' page - https://github.com/DivanteLtd/shopware-pwa/projects/15#card-41063261 |
@akrajna breadcrumbs in checkout depends on from which page user enter the checkout e.g - no breadcrumbs on checkout page |
Works fine. As discussed there are breadcrumbs on categories page and checkout, we will work on breadcrumbs on product page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to have i18n here, please add this for English and German language, so after the language change there will be a difference to see
|
||
if (breadcrumbs.length > 0) { | ||
breadcrumbs.unshift({ | ||
text: "Home", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not meet Acceptance criterium:
Text editable through i18n
Changes
closes #846
Checklist