This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
feat(client): filters handler for store-api #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/9zdmcy4qq |
|
💙 shopware-pwa-canary successfully deployed at https://c58c0a0410b50f5a36eee27619b3db7acc736262.shopware-pwa-canary.preview.storefrontcloud.io |
patzick
approved these changes
May 14, 2020
| @@ -74,7 +77,16 @@ export const convertSearchCriteria = ( | |||
| } | |||
|
|
|||
| if (filters && filters.length) { | |||
| params.filter = filters; | |||
| // append filters in store-api style using convertToStoreApiFilters | |||
| if (apiType && apiType === ApiType.store) { | |||
There was a problem hiding this comment.
could be just
Suggested change
| if (apiType && apiType === ApiType.store) { | |
| if (apiType === ApiType.store) { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds the possibility of filtering within product-listing endpoint.
Checklist