Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

fix(theme): update contextToken only if has changed #195

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented Dec 8, 2019

No description provided.

@patzick patzick added the WIP label Dec 8, 2019
@github-actions
Copy link

github-actions bot commented Dec 8, 2019

Deploy preview for website ready!

Built with commit 0d604d9

https://shopware-pwa-5k142nz10.now.sh

@patzick
Copy link
Collaborator Author

patzick commented Dec 8, 2019

Resolved problem with first render after on Server. Nuxt was trying to set a cookie after the request sent which caused a problem with initial render.
At first, I thought it was caused by modifying global Axios in response interceptor, but cookies were the real reason. They can fail silently with no impact on the application.

@patzick patzick changed the title wip(theme): update contextToken only if has changed fix(theme): update contextToken only if has changed Dec 8, 2019
@patzick patzick removed the WIP label Dec 8, 2019
@patzick patzick marked this pull request as ready for review December 8, 2019 16:08
@patzick patzick merged commit c61ee74 into master Dec 9, 2019
@patzick patzick deleted the fix/theme/ssr-Cannot-set-headers-after-they-are-sent-to-the-client branch December 9, 2019 11:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants