Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

fix(default-theme): coupon code submission no longer results in error #1345

Merged
merged 31 commits into from
Mar 9, 2021

Conversation

niklaswolf
Copy link
Collaborator

Changes

closes #1325

  • prevent empty coupon code submission
  • fix promotion code notifications

Checklist

@niklaswolf
Copy link
Collaborator Author

@mkucmus are there any valid promotion codes configured in the demo backend?
I'd need one to test also the "valid coupon code" case.
Invalid coupon code case seems to work now.

@mkucmus
Copy link
Collaborator

mkucmus commented Feb 8, 2021

@mkucmus are there any valid promotion codes configured in the demo backend?
I'd need one to test also the "valid coupon code" case.
Invalid coupon code case seems to work now.

here's your special code: GETPROMO2021 gives 50% off 👍

@niklaswolf
Copy link
Collaborator Author

That's so generous, thanks a lot 😉😂

@vercel
Copy link

vercel bot commented Mar 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/DJUutpWU9h6fAjn2v7Y4YLxV3vVq
✅ Preview: https://shopware-pwa-d-git-fork-mothership-gmbh-1325-coupon-code-764386.vercel.app

@vercel vercel bot temporarily deployed to preview March 4, 2021 12:03 Inactive
@vercel vercel bot temporarily deployed to preview March 8, 2021 15:24 Inactive
@vercel vercel bot temporarily deployed to preview March 9, 2021 09:33 Inactive
Copy link
Collaborator

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@patzick patzick merged commit 780759d into vuestorefront:master Mar 9, 2021
@mothership-nik-wolf mothership-nik-wolf deleted the 1325-coupon-code-error branch April 7, 2021 14:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Empty coupon code throws 500 in checkout
3 participants