Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat(default-theme): added same site cookie attribute #1123

Merged
merged 4 commits into from
Sep 28, 2020

Conversation

Malwurf
Copy link
Collaborator

@Malwurf Malwurf commented Sep 22, 2020

Changes

closes #955

Added sameSite attribute to cookies which are set when project instance is creating.

Screenshot from 2020-09-23 12-29-22

Checklist

@vercel
Copy link

vercel bot commented Sep 22, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/1ocbgts2c
✅ Preview: In Progress

@github-actions
Copy link

github-actions bot commented Sep 22, 2020

💙 shopware-pwa-canary successfully deployed at https://45e1c559a925dc56bd44c21281bc73559d875b23.shopware-pwa-canary.preview.storefrontcloud.io

@vercel vercel bot temporarily deployed to preview September 23, 2020 10:25 Inactive
@Malwurf Malwurf changed the title feat(default-theme): added same site strict cookie attribute feat(default-theme): added same site cookie attribute Sep 23, 2020
@Malwurf Malwurf marked this pull request as ready for review September 23, 2020 10:33
@vercel vercel bot temporarily deployed to preview September 23, 2020 10:34 Inactive
@vercel vercel bot temporarily deployed to preview September 28, 2020 13:40 Inactive
Copy link
Collaborator

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and we are safer now 🔒

@mkucmus mkucmus merged commit 8d2f3fb into master Sep 28, 2020
@mkucmus mkucmus deleted the feat/define-samesite-cookies-#955 branch September 28, 2020 13:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define SameSite cookie's attribute
2 participants