Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

fix(cms): image text blocks distinction #1065 (#1070) #1070

Merged
merged 4 commits into from
Sep 11, 2020

Conversation

Malwurf
Copy link
Collaborator

@Malwurf Malwurf commented Sep 3, 2020

Changes

closes #1065

Created separate file/block for (image text block)

Reverted changes in (text on image block)

Fixed text on image banner at homepage:
Screenshot from 2020-09-03 12-19-42

Image next to text still looks good:
Screenshot from 2020-09-03 12-19-57

Checklist

@vercel
Copy link

vercel bot commented Sep 3, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/k03pr2xh7
✅ Preview: https://shopware-pwa-docs-git-fix-image-text-blocks-distinction-1065.shopware-pwa.vercel.app

@CLAassistant
Copy link

CLAassistant commented Sep 3, 2020

CLA assistant check
All committers have signed the CLA.

@Malwurf Malwurf requested a review from akrajna September 3, 2020 10:22
@github-actions
Copy link

github-actions bot commented Sep 3, 2020

💙 shopware-pwa-canary successfully deployed at https://bbcb6377bbe01073afce2338c6b073f13b807ed2.shopware-pwa-canary.preview.storefrontcloud.io

Copy link
Collaborator

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it's what we need 🚀

@vercel vercel bot temporarily deployed to preview September 4, 2020 07:01 Inactive
Copy link
Collaborator

@akrajna akrajna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the hero image added to the page does not display picture (see the baby category)

@vercel vercel bot temporarily deployed to preview September 11, 2020 11:13 Inactive
@patzick patzick merged commit e296bea into master Sep 11, 2020
@patzick patzick deleted the fix/image-text-blocks-distinction-#1065 branch September 11, 2020 11:14
@patzick patzick changed the title Fix/image text blocks distinction #1065 fix(cms): image text blocks distinction #1065 (#1070) Sep 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] image-text and text-on-image blocks distinction
5 participants