Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

fix(default-theme): changed default scroll behavior #1026

Merged
merged 2 commits into from
Aug 18, 2020

Conversation

Malwurf
Copy link
Collaborator

@Malwurf Malwurf commented Aug 17, 2020

Changes

Changed default scroll behavior
closes #483

Checklist

@vercel
Copy link

vercel bot commented Aug 17, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/1tcllqkpz
✅ Preview: In Progress

@Malwurf Malwurf requested a review from akrajna August 17, 2020 13:01
@github-actions
Copy link

github-actions bot commented Aug 17, 2020

💙 shopware-pwa-canary successfully deployed at https://08d28babdc4c9d2dc913e8c2ce2bc2eacd2cf838.shopware-pwa-canary.preview.storefrontcloud.io

Copy link
Collaborator

@akrajna akrajna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great :-)

Copy link
Collaborator

@akrajna akrajna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great for product page, but if user is on product listing page and clicks on next page than the bottom of the page is visible.
expected behavior: when user is on product listing page and clicks on next page the top of the page should appear.
PLPScroll

@vercel vercel bot temporarily deployed to preview August 18, 2020 08:00 Inactive
@patzick
Copy link
Collaborator

patzick commented Aug 18, 2020

@akrajna can you create a separate issue for that?

@akrajna
Copy link
Collaborator

akrajna commented Aug 18, 2020

Of course, here it is: #1029

@patzick patzick merged commit 4968cb8 into master Aug 18, 2020
@patzick patzick deleted the fix/product-page-scroll-position-#483 branch August 18, 2020 14:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]Product Page - after opening the bottom of this page is displayed
3 participants