-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/issue/37 test cre stack in multi layer model #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this new experiment in 'multiLayerModel' directory repeat the CRE Gather Stacking process in a two layers model. Abstract the modeling step to allow to change each part of the experiment. Generalize it.
The script 'creStack.py' abstracts the building and modeling of the multi layers model with the functions 'kirchoffNewtonModeling' and 'multiLayerModel'.
The 'SConscript' it is now responsible for model and data cube generation. It limits the 'SConstruct' purpose to cre stacking of the generated data cubes.
The 'aperture' parameter in 'Mgetcregather.c' defines the maximun number of traces in a cre gather. This is used to avoid generation of a big cre gather with many traces that won't be used in stacking. It also avoid to take offset coordinates that have CMPs far away from Central CMP m0 that may cause a bug. For a given offset h, the cmp coordinate m could be outside of the datacube because the CRE trajectory in m,h plane is a parabola and CMP coordinates increases fast in relation to offset.
The 'creStack.py' script is divided in several modules of a new library 'madagascarRecipes' to stablish a dependency. Because this modules are used in other packages, such as 'vfsa' or 'diffractionSimulator'. With the modules in a package, this package can use one version of the library without dependency conflict. The library can be found in: https://github.com/Dirack/madagascarRecipes
…ation into hotfix/issue/38 Update local branch of my computer repository
Hotfix/issue/38
Run multi layer experiment using non-hyperbolic CRS traveltime curve with CDS condition applied (RN=RNIP) as a stacking curve. This can be done repeating the multi layer experiment using parameter 'cds=y' in the program 'sfgetcretimecurve'.
Use 'interpolatedDataCube2' as input of sfvfsacrsnh to avoid segmentation fault error. This program uses 50 traces as standard aperture in CMP and Offset. Interpolated data has more samples so it avoids segmentation fault of the program looking for a trace outside of the model
Add parameters to control velocity scan and picking, and smoothing radius
…nto feature/issue/37 Update local branch with changes
Increase number of samples in CRE stacked section and repeate the experiment
This script defines a function that reports a error message when build fails. The user can control the message to be reported. SConscript has changed to use that error report. If build fails it calls 'print_build_failures' function and shows the string in 'message' variable Alias function defines aliases to call specific builds through command line. example: ~$ scons -f SConscript model It will call the building of the object defined to 'model' alias
This function exhibts a message error when build fails. It is used to show m0 and t0 variables that produced an error.
To correct this bug use a maximum aperture in CMP coordinates os CRE gather such as put zero traces if CMP coordinate of the CRE gather trace is outside of the model.
Using aperture=49 in the the program sfgetcregather with i=101 and j=73 runs without bug. Meanwhile, running with aperture=50 ends with the bug referenced in this issue. This probably occurs because trace number 50 has a CMP coordinate out of the model, m[50]=5.026 (I've checked in 'creMhcoordinate' file). Please reference this commit to hotfix/issue/38 discussion.
Stores the maximum CMP coordinate of the model in a variable mMax in the program 'MgetcreGather.c' and check if the CMP coordinate is out of the bounds of the model. Put zero values in the sample of this trace.
Hotfix/issue/38 bug correction in sfgetcregather
Add report function and run cre and cds experiments. Those SConstructs are ready to run cre stack workflow in the multi layer model.
@Dirack, Test those experiments running then in hostgator VPS |
To avoid CMP coordinate to get out of of model bounds, stack only 108 CMPs
Update bug corrections of cre and cds experiments
The concatenation step of CRE gather traces can be done in 'SConscript2' separatelly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📤 Pull Request
Description
Test the CRE stack workflow in a multi layer model two times: First, use normal CRE stack workflow, use CRE traveltime approximation as a stacking curve. Second, repeat the first experiment, this time use Non-hyperbolic CRS (with CDS condition applied) as a stacking curve.
Correct bug referenced in issue [BUG] No such file or directory error from sfgetcregather #38, put a zero trace when CMP coordinate get out of model bounds.
Resolve #37
Type of change
Please delete options that are not relevant.
Add images bellow and aditional context if needed