Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web: use a root web_sys::Node #3011

Closed
ilaborie opened this issue Sep 29, 2024 · 1 comment
Closed

Web: use a root web_sys::Node #3011

ilaborie opened this issue Sep 29, 2024 · 1 comment
Labels
web relating to the web renderer for dioxus

Comments

@ilaborie
Copy link
Contributor

Feature Request

For the web package, we could change the type of the root element to be a web_sys::Node
(instead of web_sys::Element).

This allowing to pass a web_sys::ShadowRoot instead of an element.
I'm the author of dioxus-web-component,
and currently I had to wrap content of the web component into a div.

Both Element and ShadowRoot can be converted into a Node using wasm_bindgen::JsCast

See ShadowRoot, Element

Implement Suggestion

I'm going to provide the changes in a PR
@ilaborie ilaborie mentioned this issue Sep 29, 2024
Merged
@ealmloff
Copy link
Member

ealmloff commented Sep 30, 2024 •
edited
Loading

Implemented in #3012

@ealmloff ealmloff added the web relating to the web renderer for dioxus label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
web relating to the web renderer for dioxus
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ilaborie @ealmloff