Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New apps wo router using main, errors twice on load, every time #2533

Closed
1 of 3 tasks
rogusdev opened this issue Jun 16, 2024 · 1 comment · Fixed by #2649
Closed
1 of 3 tasks

New apps wo router using main, errors twice on load, every time #2533

rogusdev opened this issue Jun 16, 2024 · 1 comment · Fixed by #2649
Labels
bug Something isn't working router Related to the router implementation

Comments

@rogusdev
Copy link
Contributor

rogusdev commented Jun 16, 2024

Problem

Apparently some new warnings are triggered by the built in behavior of dioxus. That seems undesirable 😉

ERROR GITDIR/dioxus/packages/core/src/properties.rs:144 It looks like you called the component App like a function instead of a component. Components should be called with braces like `App { prop: value }` instead of as a function
demo.js:449:21

To be clear, @ealmloff , it looks like this is from https://github.com/DioxusLabs/dioxus/pull/2461/files#diff-e6199434c34c915eed237c16bcdf8167d70272bafd878fb3c95054939c585e11R122

Steps To Reproduce

Repro with dx new, false router, use dioxus local with main HEAD instead of crate (dioxus = { path = "../dioxus/packages/dioxus", features = ["web"] }), then dx serve

Expected behavior

Don't throw errors for a starter app automatically!

Screenshots

If applicable, add screenshots to help explain your problem.

Environment:

  • Dioxus version: main
  • App platform: web

Questionnaire

  • I'm interested in fixing this myself but don't know where to start
  • I would like to fix and I have a solution
  • I don't have time to fix this right now, but maybe later
@ealmloff ealmloff added bug Something isn't working router Related to the router implementation labels Jun 17, 2024
@rogusdev
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working router Related to the router implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants