Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rink: Use ratatui instead of tui-rs #1311

Closed
undersquire opened this issue Aug 6, 2023 · 3 comments · Fixed by #1671
Closed

Rink: Use ratatui instead of tui-rs #1311

undersquire opened this issue Aug 6, 2023 · 3 comments · Fixed by #1671
Labels

Comments

@undersquire
Copy link

Problem

rink currently depends on tui-rs, which is no longer maintained.

Solution

Switch to ratatui, which has been named the official successor to tui-rs.

It should just be a drop-in replacement, simply changing the Cargo.toml entry to:

tui = { package = "ratatui", version = "0.22", features = ["all-widgets"]}
@Esales301080
Copy link

Nice

@ealmloff ealmloff added the tui label Aug 7, 2023
@ealmloff
Copy link
Member

ealmloff commented Aug 7, 2023

We don't really use the TUI crate for anything except rendering. Wrap their widget trait and events. We could switch to a more raw terminal rendering crate like termwiz. Termwiz supports images, and raw pixel graphics on some terminals unlike TUI or ratatui

@undersquire
Copy link
Author

We could switch to a more raw terminal rendering crate like termwiz. Termwiz supports images, and raw pixel graphics on some terminals unlike TUI or ratatui

That does sound like a good idea. I have looked into termwiz and it seems like a better option if Rink isn't using any widgets from tui-rs. (also ratatui does have a termwiz backend if dioxus-tui ever does find use in the widgets).

@ealmloff ealmloff added good first issue Good for newcomers and removed good first issue Good for newcomers labels Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants