Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CosmicBuffer::get_text() may return Placeholder value #138

Open
bytemunch opened this issue May 7, 2024 · 2 comments
Open

CosmicBuffer::get_text() may return Placeholder value #138

bytemunch opened this issue May 7, 2024 · 2 comments
Assignees

Comments

@bytemunch
Copy link
Collaborator

May need to reflect the actual text value in another place to guarantee correct values returned.

Alternatively teach users to put any system using get_text() after a CosmicSet system set that encompasses all plugin systems?

@bytemunch bytemunch self-assigned this May 7, 2024
@bytemunch
Copy link
Collaborator Author

Further investigation shows that my issue may be returning the underlying buffer's text instead of an active editor, which makes sense. Maybe a system ordering thing with focus stuff, maybe need an explicit apply_deferred after dropping focus?

@bytemunch
Copy link
Collaborator Author

I got tracy out and finally realised that this may be caused by focus systems running in PostUpdate whereas most user functions are run in Update, meaning that editor updates to a buffer are not applied by the time a user system tries to read them. Trying moving focus systems to Update now, if that works I'll look into moving other plugin systems out of different schedules (though I'm sure anything render-related needs to go in PostUpdate after bevy's TransformPropagate)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant