Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ECHO command #1156

Closed
lucifercr07 opened this issue Oct 19, 2024 · 3 comments
Closed

Add support for ECHO command #1156

lucifercr07 opened this issue Oct 19, 2024 · 3 comments

Comments

@lucifercr07
Copy link
Contributor

Add support for the ECHO command in DiceDB similar to the ECHO command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

@iamskp11
Copy link
Contributor

Would like to work on this @lucifercr07 . Pls assign!

@hgupta12
Copy link
Contributor

hgupta12 commented Oct 19, 2024

@lucifercr07 the ECHO command was already added to DiceDB here - #622

@lucifercr07
Copy link
Contributor Author

My bad missed it, some issue with my local docker image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants