Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match FROM and as casing in Dockerfiles #188

Closed
DominicOram opened this issue Aug 16, 2024 · 2 comments
Closed

Match FROM and as casing in Dockerfiles #188

DominicOram opened this issue Aug 16, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@DominicOram
Copy link

DominicOram commented Aug 16, 2024 •
edited
Loading

When using the template I currently get warnings that the FROM and as used in the Docker files are not consistent https://github.com/DiamondLightSource/mx_bluesky/pull/159/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557. I agree with the warnings that these look messy.

Acceptance Criteria

  • FROM and as match case whenever they are used in Dockerfiles made by the template
@DominicOram DominicOram added the good first issue Good for newcomers label Aug 16, 2024
@DominicOram DominicOram mentioned this issue Aug 16, 2024
Merged
@vredchenko
Copy link

I just attempted to fix this however it seems already fixed? @DominicOram please confirm if it's ok to close this issue or am I missing something?

Screenshot from 2024-10-21 16-43-48

@DominicOram
Copy link
Author

Yh,looks like @coretl just fixed it 6e7f62c. Happy to close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vredchenko @DominicOram