Methods without a side_outputs field may be unnecessarily included in method_id_map

[yousefmoazzam]

A variable methods_id_map is defined in the UI layer when there is iteration over the methods in the pipeline config, getting ready to build the Pipeline object:

httomo/httomo/ui_layer.py

Lines 64 to 72 in 7842bae

	method_id_map: Dict[str, MethodWrapper] = dict()
	for i, task_conf in enumerate(self.PipelineStageConfig[1:]):
	parameters = task_conf.get("parameters", dict())
	valid_refs = get_valid_ref_str(parameters)
	update_side_output_references(valid_refs, parameters, method_id_map)
	self._append_methods_list(
	i, task_conf, methods_list, parameters, method_id_map
	)

Based on how this variable is used by update_side_output_references() to map:

• a reference to a method X with an id field, from a method Y (ie, recon referencing a centering method with id: centering)
• to the method wrapper with that ID
  

  httomo/httomo/ui_layer.py

  Lines 64 to 72 in 7842bae

  	method_id_map: Dict[str, MethodWrapper] = dict()
  	for i, task_conf in enumerate(self.PipelineStageConfig[1:]):
  	parameters = task_conf.get("parameters", dict())
  	valid_refs = get_valid_ref_str(parameters)
  	update_side_output_references(valid_refs, parameters, method_id_map)
  	self._append_methods_list(
  	i, task_conf, methods_list, parameters, method_id_map
  	)

it would appear that this methods_id_map is solely for dealing with side outputs.

However, the methods_id_map includes both:

• methods with an id field
• methods without and id field

httomo/httomo/ui_layer.py

Line 110 in 7842bae

method_id_map[method.task_id] = method

and some dumb printing in the loop in UiLayer.build_pipeline() confirms this:

i = 1, method_id_map is now {'centering':
<httomo.method_wrappers.rotation.RotationWrapper object at 0x7f3d48321f60>}
i = 2, method_id_map is now {'centering':
<httomo.method_wrappers.rotation.RotationWrapper object at 0x7f3d48321f60>, 'task_2':
<httomo.method_wrappers.dezinging.DezingingWrapper object at 0x7f3d41d8c220>}
i = 3, method_id_map is now {'centering':
<httomo.method_wrappers.rotation.RotationWrapper object at 0x7f3d48321f60>, 'task_2':
<httomo.method_wrappers.dezinging.DezingingWrapper object at 0x7f3d41d8c220>, 'task_3':
<httomo.method_wrappers.generic.GenericMethodWrapper object at 0x7f3d41d8e110>}
i = 4, method_id_map is now {'centering':
<httomo.method_wrappers.rotation.RotationWrapper object at 0x7f3d48321f60>, 'task_2':
<httomo.method_wrappers.dezinging.DezingingWrapper object at 0x7f3d41d8c220>, 'task_3':
<httomo.method_wrappers.generic.GenericMethodWrapper object at 0x7f3d41d8e110>, 'task_4':
<httomo.method_wrappers.generic.GenericMethodWrapper object at 0x7f3d41d8c190>}
...

Question: given that methods_id_map seems to only be used for side outputs, is there a particular reason why methods without an id field (which produce no side outputs, and thus have no reason to be referenced) are still added to methods_id_map?