-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
707 add visr b01 1 as a beamline with devices #708
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #708 +/- ##
==========================================
+ Coverage 94.90% 94.93% +0.02%
==========================================
Files 115 116 +1
Lines 4675 4696 +21
==========================================
+ Hits 4437 4458 +21
Misses 238 238 ☔ View full report in Codecov by Sentry. |
64e281b
to
9ec6d16
Compare
this is still not connecting :( |
6df8028
to
6b6c6fd
Compare
src/dodal/beamlines/b01-1.py
Outdated
static_directory_provider = StaticDirectoryProvider("/tmp/bluesky_test_static") | ||
# set_directory_provider(PandASubdirectoryProvider()) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static_directory_provider = StaticDirectoryProvider("/tmp/bluesky_test_static") | |
# set_directory_provider(PandASubdirectoryProvider()) | |
set_directory_provider(StaticDirectoryProvider("/dls/b01-1/data/")) |
File system seems to be hiccuping (again) but when it's recovered find a sensible visit dir for this beamline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think someone needs to raise a ticket because it's been consistently like that for days.
src/dodal/beamlines/b01-1.py
Outdated
# set_directory_provider(PandASubdirectoryProvider()) | ||
|
||
|
||
def panda( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a panda on this beamline? I don't see it on the beamline synoptic screen, nor is there a soft-ioc for it in kubernetes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, there is. there is aan argocd migration going on at the moment.
@marcelldls mentioned it shouldn't take too long
src/dodal/beamlines/b01-1.py
Outdated
return device_instantiation( | ||
AravisDetector, | ||
"manta", | ||
"-DI-DCAM-02:", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this device is disconnected on the synoptic for me, but -DI-DCAM-03:
is a Manta that is present?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be and Marcell is doing the IOCs into argocd migration this week afaik
Realised I was looking at BL01B: is VISR 01B or 01C? There's no synoptic screen for the latter. |
@DiamondJoseph , ViSR is the C variant and it does not have an epics screen |
5456f80
to
5adfca4
Compare
c73d3e7
to
27a7af2
Compare
panda is supposed to be off at the moment |
c4d47b2
to
17592bc
Compare
trying to fix manta connect errors, pending comment from @marcelldls |
2662aa3
to
0b89ab2
Compare
0b89ab2
to
024aad9
Compare
Fixes #707
Instructions to reviewer on how to test:
dodal connect b-01-1
is successfulChecks for reviewer
dodal connect ${BEAMLINE}