Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

[bug] red null's in manual trade mode #1116

Closed
infatrus opened this issue Jan 12, 2018 · 2 comments
Closed

[bug] red null's in manual trade mode #1116

infatrus opened this issue Jan 12, 2018 · 2 comments

Comments

@infatrus
Copy link

infatrus commented Jan 12, 2018

System information

  • OS Platform and Distribution: Ubuntu 16.04.3 LTS (Xenial Xerus)
  • Zenbot version: unstable
  • NodeJS version: 8.9.4
  • Python version: -
  • Exact command to reproduce: ./zenbot.sh trade --manual poloniex.DGB-BTC --strategy=bollinger --period_length=15m --period=15m

Describe the problem

When in manual trade mode, sell signals are not clearly visible between null's (both are red), should be grey (or other neutral color).

Source code / logs

2018-01-12 13:15:00 0.00000733 DGB-BTC +0.41% 1.33m 66 +++ +00.0000 00 00 null
2018-01-12 13:30:00 0.00000735 DGB-BTC +0.27% 3.79m 67 +++ +00.0000 00 00 null
2018-01-12 13:45:00 0.00000741 DGB-BTC +0.81% 1.06m 71 +++ +00.0000 00 00 sell
2018-01-12 14:00:00 0.00000738 DGB-BTC -0.41% 1.85m 67 +++ +00.0000 00 00 null
2018-01-12 14:15:00 0.00000729 DGB-BTC -1.22% 862.96k 57 ++ +00.0000 00 00 null

@Shawn8901
Copy link
Contributor

seems for me as a bug, that the bollinger strat sets the string 'null' instead a "real" null. So the code which chooses the color isn't working.
On other strategies there is nothing shown if there is no signal given by the strategy.

@infatrus
Copy link
Author

infatrus commented Jan 13, 2018

That's it:
Line 34 of ./extensions/strategy/bollinger/strategy.js

There is:

  • s.signal = 'null' // hold

Should be:

  • s.signal = null // hold

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants