Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

darwin.js - crossover/trendline strategy input & general .csv/.json output issues. #1044

Closed
shr00mie opened this issue Jan 4, 2018 · 1 comment

Comments

@shr00mie
Copy link
Contributor

shr00mie commented Jan 4, 2018

## darwin.js - Crossover & Trendline - parameter inconsistencies:

Existing strategies are using markup_pct:
image

Newly added crossover and trendline instead utilize markdown_buy_pct & markup_sell_pct.
image

image
(btw, should these starting ranges extend into the negative?)

Results in undefined output in .csv/.json due to:
image

Since conf.js is utilizing the syntax from crossover/trendline, I suggest that darwin.js & phenotype.js be adjusted accordingly.

While we're at it, let's toss the ema/rsi section up top and move these back into the individual strategies for aesthetic and consistency purposes.
image

## darwin.js - .csv & .json output - issues due due to inconsistent variable input/parse.
Some previous modifications to how the selector data is pulled/stored and presented (krystoph mentioned "objectify selector PR") and the recent addition of --start --end have rather decently f'd up .csv and .json output:
image

image

CSV output issues originate here:
image
if selector on 628 is modified to selector.normalized, then column A in the .csv subsequently displays correctly as the normalized selector instead of the JSON output. issue with days probably has to do input being defined here:
image
(why is start colored different? conflict?)

instead of here:
image

i THINK the .csv/.json output for the sim params component is initially being being stored here:
image
suspiciously, selector is missing from both sections. so i'm not sure if it's being properly defined as selector.normalized once pulled or what it's being set as through the process to be output as json instead of what we're expecting.

there's this portion of code which i think is trying to pull the params output and normalize the selector, but if the selector is not being properly set or is not formatted as expected, this would not have the intended outcome.
image

@shr00mie
Copy link
Contributor Author

shr00mie commented Jan 6, 2018

both of these have now been remedied. closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants