Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testcafe depends on vulnerable versions of babel-plugin-module-resolver #7456

Closed
alverdal opened this issue Jan 11, 2023 · 2 comments
Closed
Assignees

Comments

@alverdal
Copy link

What is your Scenario?

npm audit reports a HIGH alert for a dependency of testcafe.

  json5  <1.0.2 || >=2.0.0 <2.2.2
Severity: high
Prototype Pollution in JSON5 via Parse Method - https://github.com/advisories/GHSA-9c47-m6qq-7p4h
Prototype Pollution in JSON5 via Parse Method - https://github.com/advisories/GHSA-9c47-m6qq-7p4h
fix available via `npm audit fix --force`
Will install testcafe@15.1.317922, which is a breaking change
node_modules/find-babel-config/node_modules/json5
node_modules/json5
node_modules/tsconfig-paths/node_modules/json5
node_modules/vue-loader/node_modules/json5
node_modules/vue-style-loader/node_modules/json5
  find-babel-config  <=1.2.0
  Depends on vulnerable versions of json5
  node_modules/find-babel-config
    babel-plugin-module-resolver  2.3.0 - 4.1.0
    Depends on vulnerable versions of find-babel-config
    node_modules/babel-plugin-module-resolver
      testcafe  1.9.5-rc.1 - 2.2.0
      Depends on vulnerable versions of babel-plugin-module-resolver
      node_modules/testcafe

What are you suggesting?

Upgrade dependency to v5 https://github.com/tleunen/babel-plugin-module-resolver/releases/tag/v5.0.0

What alternatives have you considered?

No response

Additional context

No response

@alverdal alverdal added the TYPE: enhancement The accepted proposal for future implementation. label Jan 11, 2023
@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Jan 11, 2023
@aleks-pro
Copy link
Contributor

Hi @alverdal ,

Thank you for pointing out the issue to us. We will upgrade the babel-plugin-module-resolver package and include it in a new testcafe version.

@need-response-app need-response-app bot removed the STATE: Need response An issue that requires a response or attention from the team. label Jan 12, 2023
@aleks-pro aleks-pro self-assigned this Jan 12, 2023
@aleks-pro aleks-pro removed the TYPE: enhancement The accepted proposal for future implementation. label Jan 13, 2023
@miherlosev
Copy link
Contributor

Fixed in #7457.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants