From 075870fae19413e0bcf8e81133026b5ff3ba9273 Mon Sep 17 00:00:00 2001
From: ilyakhd <14272298+IlyaKhD@users.noreply.github.com>
Date: Fri, 30 Sep 2022 14:58:55 +0400
Subject: [PATCH] Add more scalar types

---
 js/core/index.d.ts         |   2 +-
 testing/typescript/core.ts | 229 +++++++++++++++++++++----------------
 2 files changed, 134 insertions(+), 97 deletions(-)

diff --git a/js/core/index.d.ts b/js/core/index.d.ts
index c5d0a603569e..758ae06028e3 100644
--- a/js/core/index.d.ts
+++ b/js/core/index.d.ts
@@ -19,7 +19,7 @@ export type Xor<T1, T2 = never, T3 = never, T4 = never, T5 = never, T6 = never,
   | Seal<T8, KeysOf<T1, T2, T3, T4, T5, T6, T7, T9>>
   | Seal<T9, KeysOf<T1, T2, T3, T4, T5, T6, T7, T8>>;
 
-type Scalar = string | number | Function | Date | Boolean | Array<unknown>;
+export type Scalar = undefined | null | string | String | number | Number | bigint | BigInteger | boolean | Boolean | Date | Function | Symbol | Array<unknown>;
 export type DeepPartial<T> = T extends Scalar ? T : {
   [P in keyof T]?: DeepPartial<T[P]>;
 };
diff --git a/testing/typescript/core.ts b/testing/typescript/core.ts
index 1e80a61289e5..de7ed15a1c84 100644
--- a/testing/typescript/core.ts
+++ b/testing/typescript/core.ts
@@ -1,107 +1,144 @@
+/* eslint-disable import/no-duplicates */
+/* eslint-disable import/first */
 /* eslint-disable @typescript-eslint/no-unused-vars */
 /* eslint-disable @typescript-eslint/no-type-alias */
-import {
-  PropertyType,
-} from '../../js/core';
+/* eslint-disable @typescript-eslint/consistent-type-definitions */
+/* eslint-disable @typescript-eslint/ban-types */
+/* eslint-disable no-inner-declarations */
 
 import {
   assertType,
   toAssertion,
 } from './consts';
 
-type ComplexType = {
-  a: {
-    b?: number | {
-      c: boolean;
-    };
+import { Scalar } from '../../js/core';
+
+{
+  interface TestInterface { i: any }
+  class TestClass { c: any; }
+  type TestType = { t: any };
+  function testFunction() {}
+
+  const scalar1: String extends Scalar ? true : false = true;
+  const scalar2: string extends Scalar ? true : false = true;
+  const scalar3: number extends Scalar ? true : false = true;
+  const scalar4: Number extends Scalar ? true : false = true;
+  const scalar5: bigint extends Scalar ? true : false = true;
+  const scalar6: BigInteger extends Scalar ? true : false = true;
+  const scalar7: Date extends Scalar ? true : false = true;
+  const scalar8: boolean extends Scalar ? true : false = true;
+  const scalar9: Boolean extends Scalar ? true : false = true;
+  const scalar10: null extends Scalar ? true : false = true;
+  const scalar11: undefined extends Scalar ? true : false = true;
+  const scalar12: Symbol extends Scalar ? true : false = true;
+  const scalar13: [] extends Scalar ? true : false = true;
+  const scalar14: (() => {}) extends Scalar ? true : false = true;
+  const scalar15: typeof testFunction extends Scalar ? true : false = true;
+  const scalar16: Symbol extends Scalar ? true : false = true;
+
+  const nonScalar1: TestInterface extends Scalar ? true : false = false;
+  const nonScalar2: TestClass extends Scalar ? true : false = false;
+  const nonScalar3: TestType extends Scalar ? true : false = false;
+  const nonScalar4: object extends Scalar ? true : false = false;
+}
+
+import { PropertyType } from '../../js/core';
+
+{
+  type ComplexType = {
+    a: {
+      b?: number | {
+        c: boolean;
+      };
+      x: number;
+    } | { e: string };
+  }
+  | string
+  | {
+    d: boolean | string;
+    f: string | {
+      g: number | Record<number, boolean>;
+    }[];
+  };
+
+  type AExpected = {
+    b?: BExpected;
     x: number;
   } | { e: string };
+  type BExpected = number | { c: boolean };
+  type FExpected = string | { g: GExpected }[];
+  type GExpected = number | Record<number, boolean>;
+
+  const a1: AExpected = {
+    e: 'e',
+  };
+  const a2: AExpected = {
+    x: 42,
+  };
+  const a3: AExpected = {
+    x: 42,
+    b: 1,
+  };
+  const a4: AExpected = {
+    x: 42,
+    b: {
+      c: false,
+    },
+  };
+
+  assertType<AExpected>(toAssertion(a1));
+  assertType<PropertyType<ComplexType, 'a'>>(toAssertion(a1));
+  assertType<AExpected>(toAssertion(a2));
+  assertType<PropertyType<ComplexType, 'a'>>(toAssertion(a2));
+  assertType<AExpected>(toAssertion(a3));
+  assertType<PropertyType<ComplexType, 'a'>>(toAssertion(a3));
+  assertType<AExpected>(toAssertion(a4));
+  assertType<PropertyType<ComplexType, 'a'>>(toAssertion(a4));
+
+  const b1: BExpected = 42;
+  const b2: BExpected = { c: false };
+  assertType<BExpected>(toAssertion(b1));
+  assertType<PropertyType<ComplexType, 'a.b'>>(toAssertion(b1));
+  assertType<PropertyType<PropertyType<ComplexType, 'a'>, 'b'>>(toAssertion(b1));
+  assertType<BExpected>(toAssertion(b2));
+  assertType<PropertyType<ComplexType, 'a.b'>>(toAssertion(b2));
+  assertType<PropertyType<PropertyType<ComplexType, 'a'>, 'b'>>(toAssertion(b2));
+
+  assertType<boolean>(toAssertion(false));
+  assertType<PropertyType<ComplexType, 'a.b.c'>>(toAssertion(false));
+  assertType < PropertyType<PropertyType<PropertyType<ComplexType, 'a'>, 'b'>, 'c'>>(toAssertion(false));
+  assertType<boolean>(toAssertion(true));
+  assertType<PropertyType<ComplexType, 'a.b.c'>>(toAssertion(true));
+  assertType < PropertyType<PropertyType<PropertyType<ComplexType, 'a'>, 'b'>, 'c'>>(toAssertion(true));
+
+  assertType<boolean | string>(toAssertion(true));
+  assertType<PropertyType<ComplexType, 'd'>>(toAssertion(true));
+  assertType<boolean | string>(toAssertion(false));
+  assertType<PropertyType<ComplexType, 'd'>>(toAssertion(false));
+  assertType<boolean | string>(toAssertion('some string'));
+  assertType<PropertyType<ComplexType, 'd'>>(toAssertion('some string'));
+
+  assertType<string>(toAssertion('some string'));
+  assertType<PropertyType<ComplexType, 'a.e'>>(toAssertion('some string'));
+  assertType<PropertyType<PropertyType<ComplexType, 'a'>, 'e'>>(toAssertion('some string'));
+
+  const f1: FExpected = 'some string';
+  const f2: FExpected = [{ g: 42 }];
+  const f3: FExpected = [{ g: { 1: false, 2: false, 3: true } }];
+
+  assertType<FExpected>(toAssertion(f1));
+  assertType<PropertyType<ComplexType, 'f'>>(toAssertion(f1));
+  assertType<FExpected>(toAssertion(f2));
+  assertType<PropertyType<ComplexType, 'f'>>(toAssertion(f2));
+  assertType<FExpected>(toAssertion(f3));
+  assertType<PropertyType<ComplexType, 'f'>>(toAssertion(f3));
+
+  const g1: GExpected = 42;
+  const g2: GExpected = { 1: false, 2: false, 3: true };
+  assertType<GExpected>(toAssertion(g1));
+  assertType<PropertyType<ComplexType, 'f.g'>>(toAssertion(g1));
+  assertType<PropertyType<PropertyType<ComplexType, 'f'>, 'g'>>(toAssertion(g1));
+  assertType<GExpected>(toAssertion(g2));
+  assertType<PropertyType<ComplexType, 'f.g'>>(toAssertion(g2));
+  assertType<PropertyType<PropertyType<ComplexType, 'f'>, 'g'>>(toAssertion(g2));
 }
-| string
-| {
-  d: boolean | string;
-  f: string | {
-    g: number | Record<number, boolean>;
-  }[];
-};
-
-type AExpected = {
-  b?: BExpected;
-  x: number;
-} | { e: string };
-type BExpected = number | { c: boolean };
-type FExpected = string | { g: GExpected }[];
-type GExpected = number | Record<number, boolean>;
-
-const a1: AExpected = {
-  e: 'e',
-};
-const a2: AExpected = {
-  x: 42,
-};
-const a3: AExpected = {
-  x: 42,
-  b: 1,
-};
-const a4: AExpected = {
-  x: 42,
-  b: {
-    c: false,
-  },
-};
-
-assertType<AExpected>(toAssertion(a1));
-assertType<PropertyType<ComplexType, 'a'>>(toAssertion(a1));
-assertType<AExpected>(toAssertion(a2));
-assertType<PropertyType<ComplexType, 'a'>>(toAssertion(a2));
-assertType<AExpected>(toAssertion(a3));
-assertType<PropertyType<ComplexType, 'a'>>(toAssertion(a3));
-assertType<AExpected>(toAssertion(a4));
-assertType<PropertyType<ComplexType, 'a'>>(toAssertion(a4));
-
-const b1: BExpected = 42;
-const b2: BExpected = { c: false };
-assertType<BExpected>(toAssertion(b1));
-assertType<PropertyType<ComplexType, 'a.b'>>(toAssertion(b1));
-assertType<PropertyType<PropertyType<ComplexType, 'a'>, 'b'>>(toAssertion(b1));
-assertType<BExpected>(toAssertion(b2));
-assertType<PropertyType<ComplexType, 'a.b'>>(toAssertion(b2));
-assertType<PropertyType<PropertyType<ComplexType, 'a'>, 'b'>>(toAssertion(b2));
-
-assertType<boolean>(toAssertion(false));
-assertType<PropertyType<ComplexType, 'a.b.c'>>(toAssertion(false));
-assertType < PropertyType<PropertyType<PropertyType<ComplexType, 'a'>, 'b'>, 'c'>>(toAssertion(false));
-assertType<boolean>(toAssertion(true));
-assertType<PropertyType<ComplexType, 'a.b.c'>>(toAssertion(true));
-assertType < PropertyType<PropertyType<PropertyType<ComplexType, 'a'>, 'b'>, 'c'>>(toAssertion(true));
-
-assertType<boolean | string>(toAssertion(true));
-assertType<PropertyType<ComplexType, 'd'>>(toAssertion(true));
-assertType<boolean | string>(toAssertion(false));
-assertType<PropertyType<ComplexType, 'd'>>(toAssertion(false));
-assertType<boolean | string>(toAssertion('some string'));
-assertType<PropertyType<ComplexType, 'd'>>(toAssertion('some string'));
-
-assertType<string>(toAssertion('some string'));
-assertType<PropertyType<ComplexType, 'a.e'>>(toAssertion('some string'));
-assertType<PropertyType<PropertyType<ComplexType, 'a'>, 'e'>>(toAssertion('some string'));
-
-const f1: FExpected = 'some string';
-const f2: FExpected = [{ g: 42 }];
-const f3: FExpected = [{ g: { 1: false, 2: false, 3: true } }];
-
-assertType<FExpected>(toAssertion(f1));
-assertType<PropertyType<ComplexType, 'f'>>(toAssertion(f1));
-assertType<FExpected>(toAssertion(f2));
-assertType<PropertyType<ComplexType, 'f'>>(toAssertion(f2));
-assertType<FExpected>(toAssertion(f3));
-assertType<PropertyType<ComplexType, 'f'>>(toAssertion(f3));
-
-const g1: GExpected = 42;
-const g2: GExpected = { 1: false, 2: false, 3: true };
-assertType<GExpected>(toAssertion(g1));
-assertType<PropertyType<ComplexType, 'f.g'>>(toAssertion(g1));
-assertType<PropertyType<PropertyType<ComplexType, 'f'>, 'g'>>(toAssertion(g1));
-assertType<GExpected>(toAssertion(g2));
-assertType<PropertyType<ComplexType, 'f.g'>>(toAssertion(g2));
-assertType<PropertyType<PropertyType<ComplexType, 'f'>, 'g'>>(toAssertion(g2));