Consider nix installer being explicit

[domenkozar]

Installer action comes with nix.conf options, different installers, etc.

One way would be to expose those via this action, but then what's the point of doing that? :)

[cole-h]

What do you think about adding an install_nix input, defaulting to true, that will continue the current behavior, or if switched to false, allow the user to use their own Nix install step(s)?

I added the install-nix-action by default because it's easier to keep in sync when we have internal repos using it (as opposed to only updating one repo's install_url because it needs some new feature or bugfix and now there's 2 different versions in use).

[domenkozar]

install_nix sounds good :)

because it needs some new feature or bugfix and now there's 2 different versions in use).

That makes sense, but it's surprising/out of control for those that don't maintain this action :)

I'd expect the install action to always default to the latest Nix (starting with Nix 2.4 rc1).

As soon as that changes to a bugfix release you might need internally, that's unexpected for me as a downstream user.

Thanks for explaining the motivation!

[cole-h]

Definitely fair.

Is 2.4pre-rc1 the same as what you're referring to as "Nix 2.4 rc1"? (It's the pre that's throwing me off -- is it "pre-rc1" or "2.4pre" because it's not a true 2.4 release yet.)

[domenkozar]

It is, sorry for the confusion (pre-rc1 is a weird naming).

[cole-h]

Just an update (in case you didn't see the linked PR) -- it doesn't look like there's any way to have a conditional step in a composite action. I've filed a ticket with GitHub support to see if there's a reason for this, or if there's any chance they will support the if: key in composite action steps. They haven't gotten back to me yet, but I think I'll wait a little bit before going nuclear and just removing the step altogether (and cutting a v3).

I'll keep this issue posted on further updates.

[grahamc]

If we don't hear back from GitHub by Wednesday we're going to go ahead and cut the install step out in a v3 release.

[cole-h]

So, GitHub support got back to me, and there are currently no plans to support the if: key in composite actions like this one. I'll cut a v3 shortly.

[cole-h]

I just cut v3. Thanks for your feedback :)