Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing SQL Server keywords #191

Closed
RAV64 opened this issue Aug 11, 2023 · 2 comments · Fixed by #192
Closed

Adding missing SQL Server keywords #191

RAV64 opened this issue Aug 11, 2023 · 2 comments · Fixed by #192

Comments

@RAV64
Copy link

RAV64 commented Aug 11, 2023

Would it be possible to have this parser also include SQL Server specific keywords, for example:

NVARCHAR
NCHAR
DATETIME2
DATETIMEOFFSET
SMALLDATETIME
TIME
SMALLMONEY
VARBINARY
IMAGE

Also, some functions are missing, for example:

OBJECT_ID

I assume others too, this is the only one I checked :)

I can also write a PR for this if that's an issue.

Thanks! ❤️

@dmfay
Copy link
Collaborator

dmfay commented Aug 11, 2023

types absolutely! As for functions, we've been moving away from special-casing those -- for example, there's no standalone count or rank anymore. object_id should already resolve as an invocation afaik, and that'll have the name field.

@matthias-Q
Copy link
Collaborator

NVARCHAR/NCHAR as a type is easy, but referencing it might be a bit more challenging:

SELECT * FROM tab WHERE  col = N'BLUBB' 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants