Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new ModelRoot class #728

Closed
DirkEilander opened this issue Jan 10, 2024 · 1 comment · Fixed by #757
Closed

new ModelRoot class #728

DirkEilander opened this issue Jan 10, 2024 · 1 comment · Fixed by #757
Assignees
Labels
Enhancement New feature or request Model issues related to the Model class and its subclasses V1
Milestone

Comments

@DirkEilander
Copy link
Contributor

DirkEilander commented Jan 10, 2024

Kind of request

Changing existing functionality

Enhancement Description

Currently the Model._root is a Path instance and a separate property from the Model._write and Model._read properties and methods which are derived from the read/writing mode and used by Model._assert_read_mode and Model._assert_write_mode methods. The Model.set_root method sets both the root and the mode and creates a folder structure based on the Models._FOLDERS class property.

These methods could be combined into a single ModelRoot class, which might be a good starting point to improve the read/write behavior together with #671 In addition I think we should leave the setting up of a folder structure to write methods and only create a model root folder when setting a new root as not all folders are used by each instance of a model and this behavior is rather unclear.

Use case

This mainly targets better code structure. See #671 for an example

Additional Context

No response

@DirkEilander DirkEilander added Enhancement New feature or request Needs refinement issue still needs refinement labels Jan 10, 2024
@DirkEilander DirkEilander added this to the v1.0 milestone Jan 10, 2024
@DirkEilander DirkEilander added the Model issues related to the Model class and its subclasses label Jan 10, 2024
@savente93 savente93 added V1 and removed V1 labels Jan 11, 2024
@savente93 savente93 modified the milestones: v1.0, 2024 - Q1 Jan 12, 2024
@savente93 savente93 self-assigned this Jan 12, 2024
@alimeshgi alimeshgi removed the Needs refinement issue still needs refinement label Jan 25, 2024
@savente93 savente93 mentioned this issue Jan 30, 2024
6 tasks
@savente93
Copy link
Contributor

@DirkEilander Now that #788 and #786 are merged can we close this issue or is still more necessary?

@savente93 savente93 modified the milestones: v1.0 beta, v1.0 alpha May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Model issues related to the Model class and its subclasses V1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants