You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the Model._root is a Path instance and a separate property from the Model._write and Model._read properties and methods which are derived from the read/writing mode and used by Model._assert_read_mode and Model._assert_write_mode methods. The Model.set_root method sets both the root and the mode and creates a folder structure based on the Models._FOLDERS class property.
These methods could be combined into a single ModelRoot class, which might be a good starting point to improve the read/write behavior together with #671 In addition I think we should leave the setting up of a folder structure to write methods and only create a model root folder when setting a new root as not all folders are used by each instance of a model and this behavior is rather unclear.
Use case
This mainly targets better code structure. See #671 for an example
Additional Context
No response
The text was updated successfully, but these errors were encountered:
Kind of request
Changing existing functionality
Enhancement Description
Currently the
Model._root
is aPath
instance and a separate property from theModel._write
andModel._read
properties and methods which are derived from the read/writing mode and used byModel._assert_read_mode
andModel._assert_write_mode
methods. TheModel.set_root
method sets both the root and the mode and creates a folder structure based on theModels._FOLDERS
class property.These methods could be combined into a single ModelRoot class, which might be a good starting point to improve the read/write behavior together with #671 In addition I think we should leave the setting up of a folder structure to write methods and only create a model root folder when setting a new root as not all folders are used by each instance of a model and this behavior is rather unclear.
Use case
This mainly targets better code structure. See #671 for an example
Additional Context
No response
The text was updated successfully, but these errors were encountered: